refactor: store user shortcodes as [user=ID] #2606

wescopeland · 2024-08-11T15:41:28Z

Command to run after deploy:

sail artisan ra:community:migrate-user-shortcodes

This PR adjusts how [user] shortcodes are stored in the ForumTopicComment and messages tables.

With this PR's changes, a body like:

Hello [user=Scott]. I hope you are having a nice day.

will now be stored in the DB as:

Hello [user=1]. I hope you are having a nice day.

This is all done invisibly to the end user. A command is included to migrate the ForumTopicComment and messages table to the new format:

sail artisan ra:community:migrate-user-shortcodes
sail artisan ra:community:migrate-user-shortcodes --undo

app/Helpers/shortcode.php

app/Support/Shortcode/Shortcode.php

wescopeland added 2 commits August 11, 2024 11:06

refactor: store user shortcodes as [user=ID]

8e97d87

refactor: include messages too

2e3b536

wescopeland requested a review from a team August 11, 2024 15:41

Merge branch 'master' into user-shortcodes-as-ids

0663363

wescopeland added the deployment/command Includes an Artisan command that needs to be run before/during deployment label Aug 11, 2024

Jamiras reviewed Aug 17, 2024

View reviewed changes

app/Helpers/shortcode.php Show resolved Hide resolved

app/Support/Shortcode/Shortcode.php Outdated Show resolved Hide resolved

wescopeland added 5 commits August 17, 2024 12:27

fix: address pr feedback

505baf1

chore: add missing changes

4051a54

chore: fix some variable silliness

040b903

fix: address pr feedback

e48cd54

Merge branch 'master' into user-shortcodes-as-ids

fa246b6

Jamiras approved these changes Aug 19, 2024

View reviewed changes

Merge branch 'master' into user-shortcodes-as-ids

81dc770

wescopeland merged commit 9443167 into RetroAchievements:master Aug 25, 2024
5 checks passed

wescopeland deleted the user-shortcodes-as-ids branch August 25, 2024 02:47

Provide feedback