feat(download): add events to the external links #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
commented
Aug 15, 2024
There was a problem hiding this comment.
These changes are so that we can see events being emitted while doing local development.
| <x-link | ||
| href="{{ $emulator['download_url'] }}" | ||
| target="_blank" | ||
| class="plausible-event-name=Download+Link+Click plausible-event-emulator={{ $emulator['handle'] }}" |
| @@ -194,6 +194,7 @@ | |||
| 'handle' => 'Dolphin', | |||
| 'active' => true, | |||
| 'link' => 'https://wiki.dolphin-emu.org/index.php?title=Main_Page', | |||
| 'description' => '<strong>NOTE:</strong> Requires a development version of 2407-68 or higher.', | |||
There was a problem hiding this comment.
I've already updated this on the server.
Jamiras
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, I'd like to redesign this page. However, given that it gets a lot of traffic, we should ensure any redesign doesn't hurt the page's current activity.
Now that we have analytics (see here), we can start measuring how often the buttons on this page are clicked in order to run a redesign through an A/B test later. Ideally, a redesign will either perform the same or better than the current page.
How to test this PR: