Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-push): run phpunit in parallel mode when detecting a macOS or Linux system #2652

Merged
merged 7 commits into from
Aug 31, 2024

Conversation

wescopeland
Copy link
Member

Parallel mode is incompatible with Windows.

In pre-push, explicitly check if the developer is using macOS or Linux. If those operating systems are detected, use parallel mode. If they aren't detected, continue with today's behavior of using vanilla phpunit.

@wescopeland wescopeland requested a review from a team August 28, 2024 12:07
.hooks/pre-push Outdated Show resolved Hide resolved
.hooks/pre-push Outdated Show resolved Hide resolved
.hooks/pre-push Outdated Show resolved Hide resolved
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed functional on linux

@wescopeland wescopeland merged commit 75fba17 into RetroAchievements:master Aug 31, 2024
5 checks passed
@wescopeland wescopeland deleted the pre-push-parallel branch August 31, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants