feat(manage): add 'View Comments' button to game hash management table #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple change to add a "View Comments" button to the game hash management table:
If there is at least one non-system comment, the button color changes. Automated system comments are not included in the count.
The button leads the user to the dedicated comments page for the game's hashes.
I originally explored trying to get these comments inline in the table somehow, but Filament is very unhappy with trying to do this. This seems like the next best option.
Next steps:
/game/[game]/hashes/manageroute so this stuff can live entirely in Filament.