Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messages): replace [user=ID] in email/discord previews with @username #2687

Merged

Conversation

wescopeland
Copy link
Member

Webhook and email previews for inbox messages are currently showing [user=ID] rather than the username (see here).

This PR adds an action which finds these shortcodes in the message content and swaps in the usernames.

@wescopeland wescopeland requested a review from a team September 12, 2024 12:30
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified private messages and editing. Assuming discord integration is fine based on changes matching private messaging.

@wescopeland wescopeland merged commit 2b951fa into RetroAchievements:master Sep 14, 2024
6 checks passed
@wescopeland wescopeland deleted the discord-inbox-usernames branch September 14, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants