-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GameSuggestionEngine class #2978
Open
wescopeland
wants to merge
5
commits into
RetroAchievements:master
Choose a base branch
from
wescopeland:game-suggestion-engine-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add GameSuggestionEngine class #2978
wescopeland
wants to merge
5
commits into
RetroAchievements:master
from
wescopeland:game-suggestion-engine-backend
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
commented
Dec 28, 2024
app/Platform/Services/GameSuggestions/Strategies/RevisedGameStrategy.php
Show resolved
Hide resolved
Jamiras
reviewed
Dec 31, 2024
app/Platform/Services/GameSuggestions/Strategies/SimilarGameStrategy.php
Show resolved
Hide resolved
app/Platform/Services/GameSuggestions/Strategies/CommonPlayersStrategy.php
Show resolved
Hide resolved
wescopeland
commented
Jan 1, 2025
Comment on lines
+84
to
+88
// We won't show the user games they already have 100% completion for. | ||
$masteredGameIds = PlayerGame::whereUserId($this->user->id) | ||
->whereAllAchievementsUnlocked() | ||
->pluck('game_id') | ||
->toArray(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I missed this in the original commit. I noticed when refreshing constantly in prod, I was never suggested a mastered game. This new logic should filter those out.
Jamiras
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork for migrating the two game suggestion pages to React. It focuses purely on implementing the back-end logic.
How to test this PR:
Navigate to both of these pages and refresh a bunch of times:
You'll see pretty-printed JSON output for the table results:
How it works:
The core of this implementation is a new
GameSuggestionEngine
class, which uses a weighted strategy pattern. Each strategy represents a different way to suggest games to users:Notice that the array values are like
[strategy, weight]
.Each suggestion strategy implements a
GameSuggestionStrategy
interface:This makes it easy to:
Here's an example of an implemented strategy to fetch a suggested game from the user's Want to Play Games list:
All of the strategies are covered by tests.
Next steps: