feat(multiset): handle r=ping
correctly
#2983
Open
+280
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how game IDs are resolved between the
patch
andping
routines to ensure consistent behavior when multiset is enabled.Key changes:
ResolveRootGameIdAction
, has been added. This action encapsulates game ID resolution logic for both endpoints.BuildClientPatchDataAction
has been modified to use this action. Tests are unchanged and all remain passing.ping
has been modified to use this action for game ID resolution if multiset is enabled.A reminder of how game ID resolution works:
The changes in this PR ensure that:
ping
matches the root-level game ID frompatch
.It's worth noting the changes in
ping
are controlled entirely by theVITE_FEATURE_MULTISET
feature flag, as clients are already sending both the game ID (g
) and the game hash MD5 (x
).Next steps:
r=startsession
correctly.