[Suggestion] Replace boost::locale with std::locale #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomaz82 Is that all that Boost is being used for? |
|
@hex007 no, but that is the only line of code that requires boost::locale, which is one of few parts of boost that isn't header only and thus needs a compiled library. |
|
If we ever need to switch to multi language, would this have any impact? Is it possible we may need to use more of the boost library functionality for example. |
|
@joolswills I personally would not use boost::locale for such a thing, I personally would probably look into GNU gettext ( https://www.gnu.org/software/gettext ) if I were to code multi-langual support. |
|
Yep. We would use gettext - but as I am unfamiliar with boost, I was wondering if there might be something else we might need. NP. Will merge. |
lubosz
pushed a commit
to lubosz/EmulationStation
that referenced
this pull request
Feb 29, 2020
Gridview : text, marquee, favorite & overlay can now be zOrdered
Yaoh
pushed a commit
to Yaoh/EmulationStation
that referenced
this pull request
Jul 13, 2020
[Suggestion] Replace boost::locale with std::locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics pretty close what boost::locale does, set everything to use the hosts locale, except for numerics which need to always handle dot as decimal point and not comma, else the xml parser fails. And this is close to what boost::locale does.
The benefits? Faster compile times, smaller executable and one less dependency.