runcommand - allow the runcommand log directory to be changed. #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good but if you want to do it right, you need to:
I completed what you missed on #3557. |
If an entry log_dir is made in /opt/retropie/configs/all/runcommand.cfg it will be used by runcommand for saving runcommand.log/runcommand.info files instead of the default /dev/shm It will also be used for generation of retropie_xinitrc and the generated/appended retroarch.cfg
joolswills
force-pushed
the
runcommand_log_dir
branch
from
bc71978 to
4514ad0
Compare
| @@ -119,6 +118,10 @@ function get_config() { | |||
| iniGet "image_delay" | |||
| IMAGE_DELAY="$ini_value" | |||
| [[ -z "$IMAGE_DELAY" ]] && IMAGE_DELAY=2 | |||
| iniGet "log_dir" | |||
| LOGDIR="$ini_value" | |||
| [[ -z "$LOGDIR" ]] && LOGDIR="/dev/shm" | |||
There was a problem hiding this comment.
Please modify [[ -z "$LOGDIR" ]] && LOGDIR="/dev/shm" to [[ -d "$LOGDIR" ]] || LOGDIR="/dev/shm".
If the $LOGDIR is unset or not a directory, default to /dev/shm. Though mind /dev/shm isn't guaranteed to be mounted. /tmp would be the safest bet.
|
@joolswills your commit is inconsistent with the other options being controlled via the GUI but not this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an entry log_dir is made in /opt/retropie/configs/all/runcommand.cfg it will be used by runcommand for saving runcommand.log/runcommand.info files instead of the default /dev/shm
#3554