runcommand: add a new launch prefix for X11 programs #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joolswills
force-pushed
the
runcommand-xinit-a
branch
2 times, most recently
from
6790914
to
67c033e
Compare
|
Thanks - have reworked the logic (as discussed) and updated the PR. I need to test it though (feel free to check). |
Extend the XINIT: launch prefix with two new ones in order to start a window manager before an x11 application is started. XINIT-WM: will start a window manager without the cursor XINIT-WMC: will start a window manager with the cursor This is similar to how the 'x11' backend starts an application, but without additional configuration set in 'backends.cfg'.
Removed the launching scripts for ports that were relying an x11 + window manager by using the new XINIT-WM: prefix added to runcommand.
joolswills
force-pushed
the
runcommand-xinit-a
branch
from
67c033e
to
ccbee7c
Compare
|
It looks fine - wasn't familiar with the 'match and continue/restart' for the |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework parsing of CON: and XINIT: commandline options.
Extend the XINIT: launch prefix with two new ones in order to start a window manager before an x11 application is started.
XINIT-WM: will start a window manager without the cursor
XINIT-WMC: will start a window manager with the cursor
This is similar to how the 'x11' backend starts an application, but without additional configuration set in 'backends.cfg'.
Simplified the launching of x11 enabled ports by replacing their explicit launching scripts with a launch command based on the new launch prefix.