Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parameters and debug gui to dbar4gun #3965

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

lowlevel-1989
Copy link
Contributor

@lowlevel-1989 lowlevel-1989 commented Aug 7, 2024

Now it can be configured from the RetroPie menu, and we have access to a debug gui.

Feature support

  • Standard configuration for Wii sensor
  • Only DolphinBar in mode 4
  • 4 wiimote x Dolphinbar (very fast with a single bar)
  • Generic wiimote
  • Bluetooth
  • wiimote with individual buttons
  • tilt correction
  • calibration two points
  • calibration three points

driver: https://github.com/lowlevel-1989/dbar4gun

@joolswills
Copy link
Member

joolswills commented Aug 9, 2024

Thank you for the changes - a lot of work. Cheers.

I'm unable to test currently - the only thing I saw on my phone is that maybe cmd_in wasn't declared as local. But I may be wrong as reviewing code on a phone isn't ideal.

Appreciate your leverage of the "could be documented better" RetroPie framework.

@lowlevel-1989
Copy link
Contributor Author

lowlevel-1989 commented Aug 12, 2024

Thank you for the changes - a lot of work. Cheers.

I'm unable to test currently - the only thing I saw on my phone is that maybe cmd_in wasn't declared as local. But I may be wrong as reviewing code on a phone isn't ideal.

Appreciate your leverage of the "could be documented better" RetroPie framework.

It's true, the variable was not assigned as local; I have updated it now. Thanks

@lowlevel-1989
Copy link
Contributor Author

Hi, This is OK?

@joolswills
Copy link
Member

Sorry for the delay.

I have rebased and squashed the requested fix into the first commit (with minor commit message changes). Thank you for the PR.

@joolswills joolswills merged commit 5c94733 into RetroPie:master Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants