-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash while drawing walking soldier #1668
Comments
I investigated this a bit and it is actually the drawing code that crashes the game. Investigating this is complicated by the length of the replay such that I'm checking how to save a partial replay, i.e. jump to a GF in a replay then save the remaining replay.
What exactly do you mean by that? The replay ends at this GF because the game crashed. Do you have any earlier GF where the game crashes if you observe the spot? With jumping it seems to be tricky as the crashing GF might not be drawn (draw during jump happenings only every 100 GFs or so) |
Well, that meant if you observe the spot, the game crashes before the game actually crashed when playing. Which fits your description, that it's related to drawing. The earliest crash I can reproduce is at GF 469191, thats when Player 2 loses his watchtower at 108:70 But when playing the replay up to 469200, then jumping to the spot, the game crashes as well. Hope this does answer your initial question. So you should be able to jump to GF 469100, save, continue and it should crash some GFs after. |
Uff, that is hard to reproduce in a way it allows debugging: If I save at 469100 and load that savegame it doesn't crash I was already thinking about adding a feature to save a replay at the current point, i.e. jump halfway through, save that as a new replay which can be loaded and played as-if the first replay was continued at that point. |
@Flamefire in Replay mode I jumped to 469190, saved the game, loaded the game, jumped to the spot and it crashed. So the replay now should crash as soon as you observe the spot and hit play. |
Thanks. I found the reason:
|
Create 2 tests for free fights aborted by either the attacker or defender. This reproduces issue Return-To-The-Roots#1668
Create 2 tests for free fights aborted by either the attacker or defender. This reproduces issue Return-To-The-Roots#1668
Create 2 tests for free fights aborted by either the attacker or defender. This reproduces issue Return-To-The-Roots#1668
Create 2 tests for free fights aborted by either the attacker or defender. This reproduces issue Return-To-The-Roots#1668
The game (and replay) crashes:
Although the replay seems to end at GF 469209, the replay crashes if you observe that spot early.
If you do not look at that spot (so just start the replay, jump to end, continue with P) the game doesn't crash. As soon as you jump to that spot the game will crash.
Version: 20240409
2024-05-25_19-40-22.zip
The text was updated successfully, but these errors were encountered: