Fix corrupted data on attack #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string is not NULL terminated so take length into account
Useful for debugging
This happens for new nations as new nations require overrides and new filesystem Alternative: Move override files of new nations into a subfolder of the nation folder
When a Military building is captured and recaptured before all capturers arrived they are told about that but not removed from the list in the building leading to dangling pointers Fixes Return-To-The-Roots#1452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Military building is captured and recaptured before all capturers arrived they are told about that but not removed from the list in the building leading to dangling pointers
Fixes #1452
Also fixes some output issues mentioned in the forum post on this bug report.