Don't set Harbor distance for military buildings if sea attacks are disabled and fix crash when adding objects using player-textures via LUA #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
fix_harborDistanceFlag
branch
from
effcb47 to
b0310ce
Compare
Flamefire
force-pushed
the
fix_harborDistanceFlag
branch
3 times, most recently
from
92f165c to
4347bd8
Compare
The adjustment of the Team from Random to specific should only be done for reading of (old) files, not in general or e.g. the settings transmitted when a player joins will be wrong
Flamefire
force-pushed
the
fix_harborDistanceFlag
branch
from
4347bd8 to
2772b72
Compare
Some map images are player images without player colors and hence are never uses as player images. This abstraction allows to use them no matter what they are.
Flamefire
force-pushed
the
fix_harborDistanceFlag
branch
from
cc9abcc to
63689a6
Compare
Flamefire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1477
Had to adjust the SeaWorldCreator for testing and simplified a bit of other code (use
isEnabled)I now also added the fix for #1464