Show alliances in statistic view #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
requested changes
Nov 15, 2023
There was a problem hiding this comment.
After reviewing the code I noticed that you you just copied parts of DrawPlayerBoxes which already does the "dirty stuff" I mentioned.
Maybe it makes sense to refactor the former a bit and possibly combine them a bit, like having DrawPlayerAlliances(player, drawPt) called from the existing loop where drawPt is changed to be the top-left corner of the picture and the playerboxRect and the alliance get drawn relative to that.
Flamefire
reviewed
Nov 15, 2023
auto-merge was automatically disabled
November 15, 2023 22:51
Head branch was pushed to by a user without write access
ottml
force-pushed
the
alliance_in_statistics_view
branch
from
b4ccdb7 to
53df0f0
Compare
Spikeone
reviewed
Nov 16, 2023
Spikeone
reviewed
Nov 16, 2023
ottml
force-pushed
the
alliance_in_statistics_view
branch
from
ef3633a to
ca0d0b9
Compare
Flamefire
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original:
Rttr: