Stop adding minor labels if minor phc update (#58)

* remove making it a minor * fix labels * remove useless assignment
RevenueCat · Jan 29, 2024 · 9c82c7a · 9c82c7a
1 parent e6ba247
commit 9c82c7a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/fastlane/plugin/revenuecat_internal/actions/bump_phc_version_action.rb b/lib/fastlane/plugin/revenuecat_internal/actions/bump_phc_version_action.rb
@@ -102,9 +102,7 @@ def self.is_supported?(platform)
  Helper::RevenuecatInternalHelper.commit_changes_and_push_current_branch("Version bump for #{new_version_number}")
 
  pr_title = "Updates purchases-hybrid-common to #{new_version_number}"
- type_of_bump = Helper::VersioningHelper.detect_bump_type(version_number, new_version_number)
  labels = ['phc_dependencies']
- labels << 'minor' if type_of_bump == :minor
  body = pr_title
  base_branch = "main"
 

diff --git a/spec/actions/bump_phc_version_action_spec.rb b/spec/actions/bump_phc_version_action_spec.rb
@@ -10,7 +10,7 @@
  let(:base_branch) { 'main' }
  let(:new_version) { '1.13.0' }
  let(:new_branch_name) { 'bump-phc/1.13.0' }
- let(:labels) { ['phc_dependencies', 'minor'] }
+ let(:labels) { ['phc_dependencies'] }
 
  it 'fails if version is invalid' do
  allow(FastlaneCore::UI).to receive(:interactive?).and_return(true)