Add valueInMonths helper to Period class
#1250
Conversation
| String formatted = price.getFormatted(); | ||
| Long amount = price.getAmountMicros(); | ||
| String currencyCode = price.getCurrencyCode(); | ||
| } |
There was a problem hiding this comment.
While looking at other things, I noticed that the Price class didn't have API tests. This adds them.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1250 +/- ##
============================================
+ Coverage 85.45% 85.46% +0.01%
============================================
Files 187 187
Lines 6351 6358 +7
Branches 923 924 +1
============================================
+ Hits 5427 5434 +7
Misses 567 567
Partials 357 357
☔ View full report in Codecov by Sentry. |
| @@ -41,6 +46,18 @@ data class Period( | |||
| YEAR, | |||
| UNKNOWN, | |||
| } | |||
|
|
|||
| val valueInMonths: Double | |||
There was a problem hiding this comment.
I guess detekt doesn't enforce it, but it would be nice to always add docstrings to public methods.
There was a problem hiding this comment.
Completely agree, there are actually rules to check for that but we don't have them enabled: https://detekt.dev/docs/rules/comments/#undocumentedpublicproperty. Create a linear ticket to track this.
Description
To help with the variables work needed for paywalls, this adds a helper function
valueInMonthsfor thePeriodclass. This will be used to calculate the price per month.