Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywalls: Add support for SUB_DURATION variable in paywalls #1276

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

tonidero
Copy link
Contributor

Description

Adds support for the sub_duration variable in paywalls.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (paywalls@5ebbb04). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head b74cbc8 differs from pull request most recent head 4a4330e. Consider uploading reports for the commit 4a4330e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             paywalls    #1276   +/-   ##
===========================================
  Coverage            ?   85.51%           
===========================================
  Files               ?      189           
  Lines               ?     6379           
  Branches            ?      929           
===========================================
  Hits                ?     5455           
  Misses              ?      565           
  Partials            ?      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero marked this pull request as ready for review September 21, 2023 12:30
@tonidero tonidero requested a review from a team September 21, 2023 12:30
@tonidero tonidero force-pushed the toniricodiez/pwl-213-price_per_period branch from 8d9a20d to da92f2c Compare September 21, 2023 12:42
Base automatically changed from toniricodiez/pwl-213-price_per_period to paywalls September 21, 2023 12:47
tonidero and others added 2 commits September 21, 2023 14:48
…venuecatui/data/processed/VariableProcessorTest.kt

Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>
@tonidero tonidero force-pushed the toniricodiez/pwl-218-sub_duration branch from d47c17f to 4a4330e Compare September 21, 2023 12:48
@tonidero tonidero merged commit 57b155f into paywalls Sep 21, 2023
@tonidero tonidero deleted the toniricodiez/pwl-218-sub_duration branch September 21, 2023 12:54
@NachoSoto
Copy link
Contributor

Wohooo

tonidero added a commit that referenced this pull request Oct 31, 2023
### Description
Adds support for the `sub_duration` variable in paywalls.

---------

Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants