[Paywalls] Add default locale #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
changed the title
joshdholtz
force-pushed
the
paywalls-default-locale
branch
from
7337d75
to
8b2dfed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
- Coverage 82.84% 82.78% -0.06%
==========================================
Files 222 222
Lines 7670 7680 +10
Branches 1077 1081 +4
==========================================
+ Hits 6354 6358 +4
- Misses 894 899 +5
- Partials 422 423 +1 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Aug 19, 2024
purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/PaywallData.kt
Outdated
Show resolved
Hide resolved
…ywallData.kt Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
joshdholtz
added a commit
that referenced
this pull request
Aug 22, 2024
**This is an automatic release.** ### New Features * [Paywalls] Add default locale (#1809) via Josh Holtz (@joshdholtz) * [Paywalls] Support to round+truncate prices displayed on paywalls for backend-specified countries (#1806) via James Borthwick (@jamesrb1) ### Other Changes * Publish paywall tester on each release (#1803) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Josh Holtz <me@joshholtz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support new
default_localeproperty in paywall dataDescription
If localization for preferred language isn't found, use the default locale before falling back to the first locale.
Demo
Screen.Recording.2024-08-18.at.10.52.24.PM.mov