[Paywalls] Add spacing between paragraphs and make text go full width so text align applies #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayShortway
approved these changes
Aug 26, 2024
Comment on lines
+76
to
+79
| val paragraphPadding = with(density) { style.lineHeight.toDp() } | ||
|
|
||
| Column( | ||
| verticalArrangement = Arrangement.spacedBy(paragraphPadding), |
tonidero
approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
joshdholtz
changed the title
tonidero
pushed a commit
that referenced
this pull request
Aug 29, 2024
**This is an automatic release.** ### New Features * Paywalls can use custom in-app purchase/restore code (#1777) via James Borthwick (@jamesrb1) ### Bugfixes * [Paywalls] Add spacing between paragraphs and make text go full width so text align applies (#1824) via Josh Holtz (@joshdholtz) ### Dependency Updates * Bump rexml from 3.3.4 to 3.3.6 (#1823) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `4c4b8ce` to `85e1c83` (#1812) via dependabot[bot] (@dependabot[bot]) * Adds Detekt rules for Compose. Updates detekt to 1.23.6. (#1822) via JayShortway (@JayShortway) ### Other Changes * Converts MagicWeather's Gradle files to Kotlin (#1821) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix spacing and text align consistency between Android, iOS, and web preview
Description
Markdowncomponent full width so text align applies for single line configurations