Support repurchasing of consumables in paywalls #2005
Draft
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
reviewed
Dec 23, 2024
| @@ -389,6 +389,8 @@ internal class PaywallViewModelImpl( | |||
| variableDataProvider = variableDataProvider, | |||
| activelySubscribedProductIdentifiers = customerInfo.activeSubscriptions, | |||
| nonSubscriptionProductIdentifiers = customerInfo.nonSubscriptionTransactions | |||
| // Filter out consumables so they don't get checked in valiation | |||
| .filter { !it.shouldConsume } | |||
There was a problem hiding this comment.
Hmm I'm honestly wondering if we should just remove the validation for repurchasing any product and just leave it to google to display a "Already purchased product" if the customer is already subscribed/has a non-consumed product...
There was a problem hiding this comment.
Did we have this conversation already on my prototype of this from months ago? Because this feels awkwardly familiar? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description