Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: change all jobs to use Xcode 14.x and replace xcode-install with xcodes #2421

Merged
merged 22 commits into from
Sep 6, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Apr 19, 2023

CircleCI is deprecating Xcode 13 soon.

CircleCI still recommends using xcode-install, but it breaks with Xcode 14, so it's been deprecated now. This replaces the runtime installation with xcodes.

@NachoSoto NachoSoto added the ci label Apr 19, 2023
@NachoSoto NachoSoto requested a review from a team April 19, 2023 20:59
@NachoSoto
Copy link
Contributor Author

Not sure if this works now.

@NachoSoto NachoSoto marked this pull request as ready for review April 19, 2023 21:00
@NachoSoto NachoSoto changed the title CircleCI: changed jobs to use Xcode 14.3 CircleCI: changed leftover jobs to use Xcode 14.3 Apr 19, 2023
@NachoSoto NachoSoto changed the title CircleCI: changed leftover jobs to use Xcode 14.3 CircleCI: changed leftover jobs to use Xcode 14.3 and replaced xcode-install with xcodes Apr 19, 2023
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch 3 times, most recently from 79c2d40 to 7968425 Compare April 19, 2023 23:57
@NachoSoto
Copy link
Contributor Author

NachoSoto commented Apr 20, 2023

I got simulators installing correctly, but now what?

Testing failed:
	UnitTestsHostApp (7997) encountered an error (Failed to load the test bundle. If you believe this error represents a bug, please attach the result bundle at /Users/distiller/purchases-ios/fastlane/test_output/xctest/ios/RevenueCat.xcresult. (Underlying Error: The bundle “StoreKitUnitTests” couldn’t be loaded because it is damaged or missing necessary resources. The bundle is damaged or missing necessary resources. Try reinstalling the bundle. dlopen_preflight(/Users/distiller/Library/Developer/CoreSimulator/Devices/9303FB08-F176-402B-BF32-5EFDDF8A8884/data/Containers/Bundle/Application/4B6B2F70-52FD-4D2D-8D6D-A7A191E9F72B/UnitTestsHostApp.app/PlugIns/StoreKitUnitTests.xctest/StoreKitUnitTests): Library not loaded: @rpath/XCTest.framework/XCTest
  Referenced from: /Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 14.5.simruntime/Contents/Resources/RuntimeRoot/Developer/Library/Frameworks/StoreKitTest.framework/StoreKitTest
  Reason: Incompatible library version: StoreKitTest requires version 1.0.0 or later, but XCTest provides version 0.0.0))
xctest encountered an error (Failed to install or launch the test runner. If you believe this error represents a bug, please attach the result bundle at /Users/distiller/purchases-ios/fastlane/test_output/xctest/ios/RevenueCat.xcresult. (Underlying Error: Process spawn via launchd failed. Bad file descriptor. (Underlying Error: The operation couldn’t be completed. (Mach error 9 - (os/kern) memory failure))))

@NachoSoto NachoSoto added the WIP label Apr 20, 2023
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch 3 times, most recently from eb6433c to e318919 Compare April 20, 2023 00:51
Base automatically changed from circle-ci-xcode-13-job to main April 20, 2023 15:31
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch from e318919 to 3273dee Compare April 20, 2023 15:32
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch from 3273dee to 7981c18 Compare May 22, 2023 21:55
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch 2 times, most recently from 78332d3 to 0ae6f35 Compare June 2, 2023 19:18
@@ -132,6 +132,7 @@ platform :ios do
scheme: "RevenueCat",
prelaunch_simulator: true,
output_types: 'junit',
output_style: 'raw',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ remove

@NachoSoto
Copy link
Contributor Author

NachoSoto commented Jun 2, 2023

Currently stuck on this issue: https://developer.apple.com/forums/thread/724068

Library not loaded: @rpath/XCTest.framework/XCTest
  Referenced from: /Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 14.5.simruntime/Contents/Resources/RuntimeRoot/Developer/Library/Frameworks/StoreKitTest.framework/StoreKitTest
  Reason: Incompatible library version: StoreKitTest requires version 1.0.0 or later, but XCTest provides version 0.0.0))

@NachoSoto
Copy link
Contributor Author

NachoSoto commented Jun 2, 2023

Also running into https://stackoverflow.com/questions/76115250/unit-test-failing-on-xcode-14-1

Process spawn via launchd failed.
xctest encountered an error (Failed to install or launch the test runner. If you believe this error represents a bug, please attach the result bundle at /Users/distiller/purchases-ios/fastlane/test_output/xctest/ios/RevenueCat.xcresult. (Underlying Error: Process spawn via launchd failed. Bad file descriptor. (Underlying Error: The operation couldn’t be completed. (Mach error 9 - (os/kern) memory failure))))

@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch 4 times, most recently from 499fd8a to df268e8 Compare June 4, 2023 05:14
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch from 11d0506 to 509e414 Compare September 5, 2023 21:22
@NachoSoto
Copy link
Contributor Author

@RevenueCat/coresdk this is ready to review now :D

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Glad that we finally got that working!

@@ -961,7 +948,7 @@ workflows:
xcode_version: '14.3.0'
<<: *release-branches
- installation-tests-receipt-parser:
xcode_version: '14.1.0'
xcode_version: '14.2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are still running some of these in 14.2.0. Should we be using 14.3.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this can be 14.3

But the others do need 14.2 so they run on macOS 12, which is required to install those runtimes. I added a comment for that.

.circleci/config.yml Outdated Show resolved Hide resolved
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch from 860d333 to 21b01c5 Compare September 6, 2023 16:16
@NachoSoto NachoSoto enabled auto-merge (squash) September 6, 2023 16:25
@NachoSoto NachoSoto merged commit 7d8f0e0 into main Sep 6, 2023
@NachoSoto NachoSoto deleted the circle-ci-xcode-13-jobs branch September 6, 2023 16:32
NachoSoto added a commit that referenced this pull request Sep 6, 2023
NachoSoto pushed a commit that referenced this pull request Sep 14, 2023
**This is an automatic release.**

### Bugfixes
* Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via
Toni Rico (@tonidero)
### Performance Improvements
* `OperationDispatcher`: add support for "long" delays (#3168) via
NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: add tests for ghost transfer behavior (#3135) via
NachoSoto (@NachoSoto)
* `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto
(@NachoSoto)
* `Integration Tests`: another flaky failure (#3165) via NachoSoto
(@NachoSoto)
* `Integration Tests`: fix flaky test failure due to leftover
transaction (#3167) via NachoSoto (@NachoSoto)
* `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improve flaky tests (#3163) via NachoSoto
(@NachoSoto)
* `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto)
* Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto)
* `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto)
* `CircleCI`: change all jobs to use `Xcode 14.x` and replace
`xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
NachoSoto added a commit that referenced this pull request Nov 16, 2023
See #2421.

iOS 14 + Snapshots needs a new test plan that doesn't run StoreKit tests.
NachoSoto added a commit that referenced this pull request Nov 16, 2023
See #2421.

iOS 14 + Snapshots needs a new test plan that doesn't run StoreKit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants