-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI
: change all jobs to use Xcode 14.x
and replace xcode-install
with xcodes
#2421
Conversation
Not sure if this works now. |
CircleCI
: changed jobs to use Xcode 14.3CircleCI
: changed leftover jobs to use Xcode 14.3
CircleCI
: changed leftover jobs to use Xcode 14.3CircleCI
: changed leftover jobs to use Xcode 14.3 and replaced xcode-install
with xcodes
79c2d40
to
7968425
Compare
I got simulators installing correctly, but now what?
|
eb6433c
to
e318919
Compare
e318919
to
3273dee
Compare
3273dee
to
7981c18
Compare
78332d3
to
0ae6f35
Compare
fastlane/Fastfile
Outdated
@@ -132,6 +132,7 @@ platform :ios do | |||
scheme: "RevenueCat", | |||
prelaunch_simulator: true, | |||
output_types: 'junit', | |||
output_style: 'raw', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently stuck on this issue: https://developer.apple.com/forums/thread/724068
|
Also running into https://stackoverflow.com/questions/76115250/unit-test-failing-on-xcode-14-1
|
499fd8a
to
df268e8
Compare
This reverts commit 44ed38e.
11d0506
to
509e414
Compare
@RevenueCat/coresdk this is ready to review now :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Glad that we finally got that working!
.circleci/config.yml
Outdated
@@ -961,7 +948,7 @@ workflows: | |||
xcode_version: '14.3.0' | |||
<<: *release-branches | |||
- installation-tests-receipt-parser: | |||
xcode_version: '14.1.0' | |||
xcode_version: '14.2.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are still running some of these in 14.2.0
. Should we be using 14.3.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this can be 14.3
But the others do need 14.2 so they run on macOS 12, which is required to install those runtimes. I added a comment for that.
860d333
to
21b01c5
Compare
**This is an automatic release.** ### Bugfixes * Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via Toni Rico (@tonidero) ### Performance Improvements * `OperationDispatcher`: add support for "long" delays (#3168) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: add tests for ghost transfer behavior (#3135) via NachoSoto (@NachoSoto) * `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto (@NachoSoto) * `Integration Tests`: another flaky failure (#3165) via NachoSoto (@NachoSoto) * `Integration Tests`: fix flaky test failure due to leftover transaction (#3167) via NachoSoto (@NachoSoto) * `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto (@NachoSoto) * `Integration Tests`: improve flaky tests (#3163) via NachoSoto (@NachoSoto) * `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto) * Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto) * `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto) * `CircleCI`: change all jobs to use `Xcode 14.x` and replace `xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
See #2421. iOS 14 + Snapshots needs a new test plan that doesn't run StoreKit tests.
See #2421. iOS 14 + Snapshots needs a new test plan that doesn't run StoreKit tests.
CircleCI
is deprecatingXcode 13
soon.CircleCI
still recommends usingxcode-install
, but it breaks with Xcode 14, so it's been deprecated now. This replaces the runtime installation withxcodes
.