`Paywalls`: fuzzy `Locale` lookups #2847

NachoSoto · 2023-07-20T11:29:37Z

Locale.current might only report a language and not a region. For example when configuring the scheme like this:

iOS localization supports this, and so should we.

Tests/UnitTests/Paywalls/PaywallDataTests.swift

NachoSoto · 2023-07-21T08:25:46Z

Sources/Paywalls/PaywallData.swift

+    /// - Note: this allows searching by `Locale` with only language code and missing region (like `en`, `es`, etc).
+    public func config(for requiredLocale: Locale) -> LocalizedConfiguration? {
+        self.localization[requiredLocale.identifier] ??
+        self.localization.first { locale, _ in


@joshdholtz we'll need to implement the same logic in the backend when requesting a specific locale (or did we decide we weren't gonna do that?)

@NachoSoto We decided against that for now so nothing to do there 😊

joshdholtz

🔥

joshdholtz · 2023-07-24T11:13:57Z

Sources/Paywalls/PaywallData.swift

+    /// - Note: this allows searching by `Locale` with only language code and missing region (like `en`, `es`, etc).
+    public func config(for requiredLocale: Locale) -> LocalizedConfiguration? {
+        self.localization[requiredLocale.identifier] ??
+        self.localization.first { locale, _ in


@NachoSoto We decided against that for now so nothing to do there 😊

`Locale.current` might only report a language and not a region. For example when configuring the scheme like this: <img width="409" alt="Screenshot 2023-07-21 at 10 23 37" src="https://github.com/RevenueCat/purchases-ios/assets/685609/c5813dca-770d-4297-8f0d-10b56cdb6445"> iOS localization supports this, and so should we.

Depends on #3002. This is the new logic for finding the locale to use ```swift var localizedConfiguration: LocalizedConfiguration { let locales: [Locale] = [.current] + Locale.preferredLocales return locales .lazy .compactMap(self.config(for:)) .first ?? self.fallbackLocalizedConfiguration } ``` And note that `config(for:)` is a fuzzy-lookup (#2847).

`Locale.current` might only report a language and not a region. For example when configuring the scheme like this: <img width="409" alt="Screenshot 2023-07-21 at 10 23 37" src="https://github.com/RevenueCat/purchases-ios/assets/685609/c5813dca-770d-4297-8f0d-10b56cdb6445"> iOS localization supports this, and so should we.

Depends on #3002. This is the new logic for finding the locale to use ```swift var localizedConfiguration: LocalizedConfiguration { let locales: [Locale] = [.current] + Locale.preferredLocales return locales .lazy .compactMap(self.config(for:)) .first ?? self.fallbackLocalizedConfiguration } ``` And note that `config(for:)` is a fuzzy-lookup (#2847).

`Locale.current` might only report a language and not a region. For example when configuring the scheme like this: <img width="409" alt="Screenshot 2023-07-21 at 10 23 37" src="https://github.com/RevenueCat/purchases-ios/assets/685609/c5813dca-770d-4297-8f0d-10b56cdb6445"> iOS localization supports this, and so should we.

Depends on #3002. This is the new logic for finding the locale to use ```swift var localizedConfiguration: LocalizedConfiguration { let locales: [Locale] = [.current] + Locale.preferredLocales return locales .lazy .compactMap(self.config(for:)) .first ?? self.fallbackLocalizedConfiguration } ``` And note that `config(for:)` is a fuzzy-lookup (#2847).

`Locale.current` might only report a language and not a region. For example when configuring the scheme like this: <img width="409" alt="Screenshot 2023-07-21 at 10 23 37" src="https://github.com/RevenueCat/purchases-ios/assets/685609/c5813dca-770d-4297-8f0d-10b56cdb6445"> iOS localization supports this, and so should we.

Depends on #3002. This is the new logic for finding the locale to use ```swift var localizedConfiguration: LocalizedConfiguration { let locales: [Locale] = [.current] + Locale.preferredLocales return locales .lazy .compactMap(self.config(for:)) .first ?? self.fallbackLocalizedConfiguration } ``` And note that `config(for:)` is a fuzzy-lookup (#2847).

@vegaro