Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: improved ISSUE_TEMPLATE #3022

Merged
merged 4 commits into from
Aug 16, 2023
Merged

GitHub: improved ISSUE_TEMPLATE #3022

merged 4 commits into from
Aug 16, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Aug 16, 2023 •
edited
Loading

  • Made the required fields a bit more obvious
  • Changed some fields to checkboxes
  • A reference to .verbose logs

@NachoSoto NachoSoto requested a review from a team August 16, 2023 15:53
tonidero
tonidero approved these changes Aug 16, 2023
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.md Outdated
6. How widespread is the issue. Percentage of devices affected.
2. [Debug logs](https://docs.revenuecat.com/docs/debugging) that reproduce the issue
6. Simulator or device:
7. Environment (Sandbox / TestFight / Production):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make these checkboxes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea let me do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

NachoSoto
NachoSoto commented Aug 16, 2023
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.md
4. **Other information** (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)
3. StoreKit version:
- [x] StoreKit 1
- [ ] StoreKit 2 (_enabled with `usesStoreKit2IfAvailable(true)`_)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was still outdated 🙈

@NachoSoto NachoSoto changed the title GitHub: added 2 fields to ISSUE_TEMPLATE GitHub: improved ISSUE_TEMPLATE Aug 16, 2023
@NachoSoto NachoSoto enabled auto-merge (squash) August 16, 2023 16:08
vegaro
vegaro reviewed Aug 16, 2023
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.md Outdated
3. StoreKit version:
- [x] StoreKit 1
- [ ] StoreKit 2 (_enabled with `usesStoreKit2IfAvailable(true)`_)
5. OS version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks!

.github/ISSUE_TEMPLATE/bug_report.md Outdated
Logs here
```

4. Steps to reproduce, with a description of expected vs. actual behavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 3 (and the following are 1 less too)

@NachoSoto NachoSoto merged commit 41b3505 into main Aug 16, 2023
@NachoSoto NachoSoto deleted the nacho/issue-template-environment branch August 16, 2023 22:39
@RCGitBot RCGitBot mentioned this pull request Aug 17, 2023
Merged
NachoSoto pushed a commit that referenced this pull request Aug 17, 2023
@RCGitBot
[AUTOMATIC] Release/4.25.5 (#3033)
7629e2a 
**This is an automatic release.**

### Bugfixes
* `PurchasesOrchestrator`: fixed callback not invoked regression during
downgrades (#3028) via NachoSoto (@NachoSoto)
* `TransactionPoster`: don't finish transactions for non-subscriptions
if they're not processed (#2841) via NachoSoto (@NachoSoto)
### Performance Improvements
* `StoreKit 2`: only listen to `StoreKit.Transaction.updates` when SK2
is enabled (#3032) via NachoSoto (@NachoSoto)
* `CustomerInfoManager`: post transactions in parallel to POST receipts
only once (#2954) via NachoSoto (@NachoSoto)
### Other Changes
* `PostedTransactionCache`: remove implementation (#3030) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improved `testCanPurchaseMultipleSubscriptions`
(#3025) via NachoSoto (@NachoSoto)
* `GitHub`: improved `ISSUE_TEMPLATE` (#3022) via NachoSoto (@NachoSoto)
* `TransactionPoster`: added transaction ID and Date to log (#3026) via
NachoSoto (@NachoSoto)
* `TransactionPoster`: fix iOS 12 test (#3018) via NachoSoto
(@NachoSoto)
* `SystemInfo`: added `ClockType` (#3014) via NachoSoto (@NachoSoto)
* `Integration Tests`: begin tests with
`UIApplication.willEnterForegroundNotification` to simulate a real app
(#3015) via NachoSoto (@NachoSoto)
* `Integration Tests`: add tests to verify `CustomerInfo`+`Offerings`
request de-dupping (#3013) via NachoSoto (@NachoSoto)
* `SwiftLint`: disable `unneeded_synthesized_initializer` (#3010) via
NachoSoto (@NachoSoto)
* Added `internal`
`NonSubscriptionTransaction.storeTransactionIdentifier` (#3009) via
NachoSoto (@NachoSoto)
* `Integration Tests`: added tests for non-renewing and non-consumable
packages (#3008) via NachoSoto (@NachoSoto)
* Expanded `EnsureNonEmptyArrayDecodable` to
`EnsureNonEmptyCollectionDecodable` (#3002) via NachoSoto (@NachoSoto)
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
@NachoSoto @MarkVillacampa
GitHub: improved ISSUE_TEMPLATE (#3022)
e7a0dd2 
- Made the required fields a bit more obvious
- Changed some fields to checkboxes
- A reference to `.verbose` logs
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
@RCGitBot @MarkVillacampa
[AUTOMATIC] Release/4.25.5 (#3033)
d08f35d 
**This is an automatic release.**

### Bugfixes
* `PurchasesOrchestrator`: fixed callback not invoked regression during
downgrades (#3028) via NachoSoto (@NachoSoto)
* `TransactionPoster`: don't finish transactions for non-subscriptions
if they're not processed (#2841) via NachoSoto (@NachoSoto)
### Performance Improvements
* `StoreKit 2`: only listen to `StoreKit.Transaction.updates` when SK2
is enabled (#3032) via NachoSoto (@NachoSoto)
* `CustomerInfoManager`: post transactions in parallel to POST receipts
only once (#2954) via NachoSoto (@NachoSoto)
### Other Changes
* `PostedTransactionCache`: remove implementation (#3030) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improved `testCanPurchaseMultipleSubscriptions`
(#3025) via NachoSoto (@NachoSoto)
* `GitHub`: improved `ISSUE_TEMPLATE` (#3022) via NachoSoto (@NachoSoto)
* `TransactionPoster`: added transaction ID and Date to log (#3026) via
NachoSoto (@NachoSoto)
* `TransactionPoster`: fix iOS 12 test (#3018) via NachoSoto
(@NachoSoto)
* `SystemInfo`: added `ClockType` (#3014) via NachoSoto (@NachoSoto)
* `Integration Tests`: begin tests with
`UIApplication.willEnterForegroundNotification` to simulate a real app
(#3015) via NachoSoto (@NachoSoto)
* `Integration Tests`: add tests to verify `CustomerInfo`+`Offerings`
request de-dupping (#3013) via NachoSoto (@NachoSoto)
* `SwiftLint`: disable `unneeded_synthesized_initializer` (#3010) via
NachoSoto (@NachoSoto)
* Added `internal`
`NonSubscriptionTransaction.storeTransactionIdentifier` (#3009) via
NachoSoto (@NachoSoto)
* `Integration Tests`: added tests for non-renewing and non-consumable
packages (#3008) via NachoSoto (@NachoSoto)
* Expanded `EnsureNonEmptyArrayDecodable` to
`EnsureNonEmptyCollectionDecodable` (#3002) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegaro vegaro vegaro left review comments

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NachoSoto @vegaro @tonidero