PurchasesOrchestrator: return early if receipt has no transactions when checking for promo offers
#3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when checking for promo offers
aboedo
reviewed
Aug 30, 2023
| @@ -426,6 +427,32 @@ class PurchasesOrchestratorTests: StoreKitConfigTestCase { | |||
| expect(self.offerings.invokedPostOffer) == false | |||
| } | |||
|
|
|||
| func testGetPromotionalOfferFailsWithIneligibleIfReceiptHasNoTransactions() async throws { | |||
There was a problem hiding this comment.
let's add another explicit test for the opposite case (doesn't fail if there are transactions). It's already indirectly tested, but having a direct one might help ensure that if other tests are refactored in some way, this one would still fail with a clear error
aboedo
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Looks great!!
We should add at least one storekit integration test. @NachoSoto should be able to help guide you through that, we can do it as a follow-up PR
NachoSoto
reviewed
Aug 30, 2023
| expect(error).to(matchError(ErrorCode.ineligibleError)) | ||
| } | ||
|
|
||
| expect(self.offerings.invokedPostOffer) == false |
NachoSoto
reviewed
Aug 30, 2023
NachoSoto
approved these changes
Aug 30, 2023
NachoSoto
approved these changes
Aug 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
+ Coverage 86.44% 86.62% +0.17%
==========================================
Files 219 219
Lines 15702 15711 +9
==========================================
+ Hits 13573 13609 +36
+ Misses 2129 2102 -27 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 5, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Sep 5, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
MarkVillacampa
added a commit
that referenced
this pull request
Sep 6, 2023
…when checking for promo offers (#3123) Avoids an extra request to the /offers endpoint in the common case where receipt has no trasactions.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids an extra request to the /offers endpoint in the common case where receipt has no trasactions.