Paywalls: always dismiss paywalls automatically after a purchase
#3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
changed the title
Paywall Tester: fix automatic dismissing after purchasingPaywalls Tester: fix automatic dismissing after purchasing
Fixes #3516. This logic only existed for `.presentPaywallIfNeeded`. However, it should apply to `PaywallView` when presented manually as well. This is also consistent with how Android works, reduces boilerplate code required by users, and removes the possibility that a paywall is still presented after a purchase, which doesn't make sense since our paywalls don't have a mode for "already subscribed".
NachoSoto
force-pushed
the
paywalls-ipad-links
branch
from
99d605a
to
054b98c
Compare
NachoSoto
changed the title
Paywalls Tester: fix automatic dismissing after purchasingPaywalls: always dismiss paywalls automatically after a purchase
NachoSoto
commented
Dec 13, 2023
| @@ -179,8 +179,6 @@ private struct PresentingPaywallModifier: ViewModifier { | |||
| ) | |||
| .onPurchaseCompleted { | |||
| self.purchaseCompleted?($0) | |||
|
|
|||
| self.close() | |||
There was a problem hiding this comment.
This is done by PaywallView automatically now.
This was referenced Dec 13, 2023
Closed
tonidero
approved these changes
Dec 14, 2023
tonidero
reviewed
Dec 14, 2023
| .onChangeOf(self.purchaseHandler.purchased) { purchased in | ||
| if purchased { | ||
| Logger.debug(Strings.dismissing_paywall) | ||
| self.dismiss() |
There was a problem hiding this comment.
I wonder if this could be considered a breaking change somewhat... Since people might have had to handle this before, would they be dismissing the paywall twice with this now?
There was a problem hiding this comment.
Even if they do, I tested it and there is no difference :) The double-dismissal becomes a no-op.
Merged
1 task
tonidero
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Dec 19, 2023
tonidero
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Dec 20, 2023
12 tasks
NachoSoto
added a commit
that referenced
this pull request
Feb 13, 2024
Follow up to #3517. This behavior is the default and not opt-in, and it doesn't make sense on footer paywalls.
NachoSoto
added a commit
that referenced
this pull request
Feb 13, 2024
joshdholtz
added a commit
that referenced
this pull request
Apr 10, 2024
### Motivation `onChangeOf` was accidentally made public in #3517 ### Description - Change scope of `onChangeOf` from `public` to `internal` - Added breaking change in v5 migration doc
fire-at-will
pushed a commit
that referenced
this pull request
Apr 15, 2024
### Motivation `onChangeOf` was accidentally made public in #3517 ### Description - Change scope of `onChangeOf` from `public` to `internal` - Added breaking change in v5 migration doc
fire-at-will
pushed a commit
that referenced
this pull request
May 13, 2024
### Motivation `onChangeOf` was accidentally made public in #3517 ### Description - Change scope of `onChangeOf` from `public` to `internal` - Added breaking change in v5 migration doc
fire-at-will
pushed a commit
that referenced
this pull request
Jun 24, 2024
### Motivation `onChangeOf` was accidentally made public in #3517 ### Description - Change scope of `onChangeOf` from `public` to `internal` - Added breaking change in v5 migration doc
fire-at-will
pushed a commit
that referenced
this pull request
Jun 28, 2024
### Motivation `onChangeOf` was accidentally made public in #3517 ### Description - Change scope of `onChangeOf` from `public` to `internal` - Added breaking change in v5 migration doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3516.
This logic only existed for
.presentPaywallIfNeeded. However, it should apply toPaywallViewwhen presented manually as well.This is also consistent with how Android works, reduces boilerplate code required by users, and removes the possibility that a paywall is still presented after a purchase, which doesn't make sense since our paywalls don't have a mode for "already subscribed".