Xcode 15.3 beta 1: fix compilation errors
#3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a proposal to address this: https://github.com/apple/swift-evolution/blob/9a8f81d75bf58c303d7aa7317a9528931ac7172c/proposals/NNNN-generalize-async-sequence.md But that's for Swift 5.11. We'll need a way to fix this on Swift 5.10. |
NachoSoto
changed the title
Xcode 15.3 beta: fix compilation errorsXcode 15.3 beta 1: fix compilation errors
NachoSoto
commented
Jan 25, 2024
| func deferMessagesIfNeeded() async throws { | ||
| // `nonisolated` required to work around Swift 5.10 issue. | ||
| // See https://github.com/RevenueCat/purchases-ios/pull/3599 | ||
| nonisolated func deferMessagesIfNeeded() async throws { |
There was a problem hiding this comment.
More context for this: https://twitter.com/nachosoto/status/1750634899810472087?s=61&t=gxxxEpOJpZ2mMeKVPUPKew
NachoSoto
added a commit
that referenced
this pull request
Jan 26, 2024
NachoSoto
pushed a commit
that referenced
this pull request
Jan 26, 2024
**This is an automatic release.** ### Bugfixes * `Xcode 15.3 beta 1`: fix compilation errors (#3599) via NachoSoto (@NachoSoto) ### Other Changes * `Xcode 15.3 beta 1`: fix warnings on tests (#3600) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
that referenced
this pull request
Jan 26, 2024
Follow up to #3599 and #3600. These `@MainActor` annotations don't work anymore because of this: > Main actor-isolated class '...' has different actor isolation from nonisolated superclass 'TestCase'; this is an error in Swift 6 They were necessary with an older version of Xcode (likely 13.x), but not anymore.
NachoSoto
added a commit
that referenced
this pull request
Feb 6, 2024
See #3599. This is listed in the [release notes](https://developer.apple.com/documentation/xcode-release-notes/xcode-15_3-release-notes) as fixed.
NachoSoto
added a commit
that referenced
this pull request
Feb 6, 2024
See #3599. This is listed in the [release notes](https://developer.apple.com/documentation/xcode-release-notes/xcode-15_3-release-notes) as fixed.
MarkVillacampa
pushed a commit
that referenced
this pull request
Feb 15, 2024
Follow up to #3599 and #3600. These `@MainActor` annotations don't work anymore because of this: > Main actor-isolated class '...' has different actor isolation from nonisolated superclass 'TestCase'; this is an error in Swift 6 They were necessary with an older version of Xcode (likely 13.x), but not anymore.
MarkVillacampa
pushed a commit
that referenced
this pull request
Feb 29, 2024
Follow up to #3599 and #3600. These `@MainActor` annotations don't work anymore because of this: > Main actor-isolated class '...' has different actor isolation from nonisolated superclass 'TestCase'; this is an error in Swift 6 They were necessary with an older version of Xcode (likely 13.x), but not anymore.
MarkVillacampa
added a commit
that referenced
this pull request
Mar 4, 2024
Follow up to #3599 and #3600. These `@MainActor` annotations don't work anymore because of this: > Main actor-isolated class '...' has different actor isolation from nonisolated superclass 'TestCase'; this is an error in Swift 6 They were necessary with an older version of Xcode (likely 13.x), but not anymore. --------- Co-authored-by: Mark Villacampa <m@markvillacampa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
InternalAPIis nowSendableto deal with new compilation errorPaywallEventStoreTypeis nowSendableSK2BeginRefundRequestHelperTypeto makeSK2BeginRefundRequestHelperSendableMockSK2BeginRefundRequestHelperto be thread-safe andSendableDebugContentViewsDebugViewModelStoreMessagesHelper