Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomerInfo: conform to Identifiable #3619

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Jan 31, 2024

This will be used by RevenueCatUI for #3620.

This will be used by `RevenueCatUI`.
@NachoSoto NachoSoto added the pr:feat A new feature label Jan 31, 2024
@NachoSoto NachoSoto requested a review from a team January 31, 2024 20:15

// swiftlint:disable:next missing_docs
public var id: String {
return self.originalAppUserId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I guess the originalAppUserId could potentially match with aliases... but then again, it's probably ok in that case, since the users are aliased together 👍

@NachoSoto NachoSoto enabled auto-merge (squash) February 1, 2024 15:37
@NachoSoto NachoSoto merged commit b167e52 into main Feb 1, 2024
24 checks passed
@NachoSoto NachoSoto deleted the customer-info-identifiable branch February 1, 2024 16:02
NachoSoto pushed a commit that referenced this pull request Feb 1, 2024
**This is an automatic release.**

### New Features
* `CustomerInfo`: conform to `Identifiable` (#3619) via NachoSoto
(@NachoSoto)
### RevenueCatUI
* `Paywalls`: new `.onPurchaseFailure` and `.onRestoreFailure` modifiers
(#3622) via NachoSoto (@NachoSoto)
* `Paywalls`: `.onRestoreCompleted` is invoked after the restore dialog
is dismissed (#3620) via NachoSoto (@NachoSoto)
* `Paywalls`: disable interactive `sheet` dismissal during purchases
(#3613) via NachoSoto (@NachoSoto)
### Other Changes
* `CircleCI`: push pods using Xcode 15 (#3614) via NachoSoto
(@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants