-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Paywalls API tests #3697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a suggestion
purchaseStarted: self.purchaseStarted, | ||
purchaseCompleted: self.purchaseOrRestoreCompleted, | ||
purchaseCancelled: self.purchaseCancelled, | ||
restoreStarted: self.restoreStarted, | ||
restoreCompleted: self.purchaseOrRestoreCompleted, | ||
purchaseFailure: self.failureHandler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add one with all the parameters but nil values? Same for the footer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
While working on #3693 I noticed we were missing some API tests that would be helpful for that PR