Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTOMATIC] Release/4.38.0 #3742

Closed
wants to merge 2 commits into from
Closed

[AUTOMATIC] Release/4.38.0 #3742

wants to merge 2 commits into from

Conversation

RCGitBot
Copy link
Contributor

@RCGitBot RCGitBot commented Mar 4, 2024

This is an automatic release.

New Features

Bugfixes

Other Changes

@RCGitBot RCGitBot requested a review from a team March 4, 2024 18:49
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but when we're ready for final ship we should maybe re-do the changelog to make things clearer

Comment on lines +1 to +12
## 4.38.0
### New Features
* Paywalls: add `updateWithDisplayCloseButton` to `PaywallViewController` (#3708) via Cesar de la Vega (@vegaro)
* New `syncAttributesAndOfferingsIfNeeded` method (#3709) via Burdock (@lburdock)
* Add targeting to `PresentedOfferingContext` (#3730) via Josh Holtz (@joshdholtz)
* Add `currentOffering(forPlacement: String)` to `Offerings` (#3707) via Guido Torres (@guido732)
* New `Package.presentedOfferingContext` (#3712) via Josh Holtz (@joshdholtz)
### Bugfixes
* Mark methods with StaticString for appUserID as deprecated (#3739) via Mark Villacampa (@MarkVillacampa)
### Other Changes
* `Xcode 15.3`: fix warnings on Integration Tests (#3603) via NachoSoto (@NachoSoto)
* [EXTERNAL] Spelling typo fix to comment (#3713) via @vdeaugustine (#3740) via Mark Villacampa (@MarkVillacampa)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a manual cleanup, where we actually explain what the feature is, point to docs and how to use it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure! I'll submit a PR to update these when ready 💪

@joshdholtz
Copy link
Member

Closing and creating a new one with a commit to fix SK2 tests

@joshdholtz joshdholtz closed this Mar 5, 2024
@joshdholtz joshdholtz deleted the release/4.38.0 branch March 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants