Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paywalls Tester 0.1 #3868

Merged
merged 1 commit into from
May 3, 2024
Merged

Paywalls Tester 0.1 #3868

merged 1 commit into from
May 3, 2024

Conversation

jamesrb1
Copy link
Contributor

@jamesrb1 jamesrb1 commented May 3, 2024

This code has been reviewed in other branches.

@RevenueCat-Danger-Bot
Copy link

RevenueCat-Danger-Bot commented May 3, 2024 •
edited
Loading

1 Message
📖 Size increase: 88.91 KB

Generated by 🚫 Danger

@jamesrb1 jamesrb1 added the pr:feat A new feature label May 3, 2024
@aboedo
Copy link
Member

aboedo commented May 3, 2024

I'd recommend removing the feat tag and replacing it with test, since it's technically not going to be a new feature in the SDK itself but rather a better way to test it.

In practice, the difference will be that test implies a patch rather than a minor version in terms of the release train, and it'll show up in the "other" section of the changelog rather than as an API change

@jamesrb1 jamesrb1 added test and removed pr:feat A new feature labels May 3, 2024
@jamesrb1 jamesrb1 requested a review from aboedo May 3, 2024 21:02
@jamesrb1 jamesrb1 enabled auto-merge (squash) May 3, 2024 21:05
@jamesrb1 jamesrb1 merged commit e4b69c3 into main May 3, 2024
24 checks passed
@jamesrb1 jamesrb1 deleted the james/paywalls-tester-0.1 branch May 3, 2024 21:18
@jamesrb1 jamesrb1 mentioned this pull request May 3, 2024
Closed
@RCGitBot RCGitBot mentioned this pull request May 8, 2024
Closed
@RCGitBot RCGitBot mentioned this pull request May 15, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Merged
vegaro pushed a commit that referenced this pull request Jun 3, 2024
@RCGitBot
[AUTOMATIC] Release/4.42.0 (#3932)
71af189 
**This is an automatic release.**

### New Features
* RemoteImage Low Res Image support (#3906) via James Borthwick
(@jamesrb1)
### Bugfixes
* [EXTERNAL] Hide decorative Paywall images from accessibility (#3886)
via @shiftingsand (#3892) via Toni Rico (@tonidero)
### Dependency Updates
* Bump rexml from 3.2.6 to 3.2.8 in
/Tests/InstallationTests/CocoapodsInstallation (#3908) via
dependabot[bot] (@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `dd5e21f` to `8ec0072`
(#3873) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Revert to use xcode 14 to fix deploys (#3929) via Cesar de la Vega
(@vegaro)
* SPMInstallation tests deployment version increase (#3922) via Cesar de
la Vega (@vegaro)
* Only install `swiftlint` on Xcode 15 jobs (#3913) via Josh Holtz
(@joshdholtz)
* Add `http_request_performed` diagnostics event (#3897) via Toni Rico
(@tonidero)
* Paywalls Tester: App Store Prep (#3889) via James Borthwick
(@jamesrb1)
* Paywalls Tester: Enable Example Paywalls in Release Mode (#3885) via
James Borthwick (@jamesrb1)
* Use Ruby 3.2 on CircleCI (#3896) via Josh Holtz (@joshdholtz)
* PaywallsTester: Remove unused code (#3884) via James Borthwick
(@jamesrb1)
* Improved Error Handling (#3883) via James Borthwick (@jamesrb1)
* Clear diagnostics file if we detect it's too big during event tracking
(#3824) via Toni Rico (@tonidero)
* Preprocessor to make select constructs public (#3880) via James
Borthwick (@jamesrb1)
* Paywalls Tester: Use key defined in CI (#3869) via James Borthwick
(@jamesrb1)
* Cleanup: Remove test storekit configuration files when importing
through SPM (#3878) via Andy Boedo (@aboedo)
* Update fastlane plugin and fix docs index path (#3872) via Toni Rico
(@tonidero)
* Update to use xcode 15.3 in CI (#3870) via Cesar de la Vega (@vegaro)
* Paywalls Tester 0.1 (#3868) via James Borthwick (@jamesrb1)
* Update config.yml for SPM repo copy (#3861) via James Borthwick
(@jamesrb1)
* Change deploy-purchase-tester to use xcode 15 (#3858) via Cesar de la
Vega (@vegaro)
nyeu pushed a commit that referenced this pull request Jun 6, 2024
@RCGitBot @nyeu
[AUTOMATIC] Release/4.42.0 (#3932)
3a7c3f9 
**This is an automatic release.**

### New Features
* RemoteImage Low Res Image support (#3906) via James Borthwick
(@jamesrb1)
### Bugfixes
* [EXTERNAL] Hide decorative Paywall images from accessibility (#3886)
via @shiftingsand (#3892) via Toni Rico (@tonidero)
### Dependency Updates
* Bump rexml from 3.2.6 to 3.2.8 in
/Tests/InstallationTests/CocoapodsInstallation (#3908) via
dependabot[bot] (@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `dd5e21f` to `8ec0072`
(#3873) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Revert to use xcode 14 to fix deploys (#3929) via Cesar de la Vega
(@vegaro)
* SPMInstallation tests deployment version increase (#3922) via Cesar de
la Vega (@vegaro)
* Only install `swiftlint` on Xcode 15 jobs (#3913) via Josh Holtz
(@joshdholtz)
* Add `http_request_performed` diagnostics event (#3897) via Toni Rico
(@tonidero)
* Paywalls Tester: App Store Prep (#3889) via James Borthwick
(@jamesrb1)
* Paywalls Tester: Enable Example Paywalls in Release Mode (#3885) via
James Borthwick (@jamesrb1)
* Use Ruby 3.2 on CircleCI (#3896) via Josh Holtz (@joshdholtz)
* PaywallsTester: Remove unused code (#3884) via James Borthwick
(@jamesrb1)
* Improved Error Handling (#3883) via James Borthwick (@jamesrb1)
* Clear diagnostics file if we detect it's too big during event tracking
(#3824) via Toni Rico (@tonidero)
* Preprocessor to make select constructs public (#3880) via James
Borthwick (@jamesrb1)
* Paywalls Tester: Use key defined in CI (#3869) via James Borthwick
(@jamesrb1)
* Cleanup: Remove test storekit configuration files when importing
through SPM (#3878) via Andy Boedo (@aboedo)
* Update fastlane plugin and fix docs index path (#3872) via Toni Rico
(@tonidero)
* Update to use xcode 15.3 in CI (#3870) via Cesar de la Vega (@vegaro)
* Paywalls Tester 0.1 (#3868) via James Borthwick (@jamesrb1)
* Update config.yml for SPM repo copy (#3861) via James Borthwick
(@jamesrb1)
* Change deploy-purchase-tester to use xcode 15 (#3858) via Cesar de la
Vega (@vegaro)
jamesrb1 pushed a commit that referenced this pull request Jun 19, 2024
@RCGitBot @jamesrb1
[AUTOMATIC] Release/4.42.0 (#3932)
71c5152 
**This is an automatic release.**

### New Features
* RemoteImage Low Res Image support (#3906) via James Borthwick
(@jamesrb1)
### Bugfixes
* [EXTERNAL] Hide decorative Paywall images from accessibility (#3886)
via @shiftingsand (#3892) via Toni Rico (@tonidero)
### Dependency Updates
* Bump rexml from 3.2.6 to 3.2.8 in
/Tests/InstallationTests/CocoapodsInstallation (#3908) via
dependabot[bot] (@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `dd5e21f` to `8ec0072`
(#3873) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Revert to use xcode 14 to fix deploys (#3929) via Cesar de la Vega
(@vegaro)
* SPMInstallation tests deployment version increase (#3922) via Cesar de
la Vega (@vegaro)
* Only install `swiftlint` on Xcode 15 jobs (#3913) via Josh Holtz
(@joshdholtz)
* Add `http_request_performed` diagnostics event (#3897) via Toni Rico
(@tonidero)
* Paywalls Tester: App Store Prep (#3889) via James Borthwick
(@jamesrb1)
* Paywalls Tester: Enable Example Paywalls in Release Mode (#3885) via
James Borthwick (@jamesrb1)
* Use Ruby 3.2 on CircleCI (#3896) via Josh Holtz (@joshdholtz)
* PaywallsTester: Remove unused code (#3884) via James Borthwick
(@jamesrb1)
* Improved Error Handling (#3883) via James Borthwick (@jamesrb1)
* Clear diagnostics file if we detect it's too big during event tracking
(#3824) via Toni Rico (@tonidero)
* Preprocessor to make select constructs public (#3880) via James
Borthwick (@jamesrb1)
* Paywalls Tester: Use key defined in CI (#3869) via James Borthwick
(@jamesrb1)
* Cleanup: Remove test storekit configuration files when importing
through SPM (#3878) via Andy Boedo (@aboedo)
* Update fastlane plugin and fix docs index path (#3872) via Toni Rico
(@tonidero)
* Update to use xcode 15.3 in CI (#3870) via Cesar de la Vega (@vegaro)
* Paywalls Tester 0.1 (#3868) via James Borthwick (@jamesrb1)
* Update config.yml for SPM repo copy (#3861) via James Borthwick
(@jamesrb1)
* Change deploy-purchase-tester to use xcode 15 (#3858) via Cesar de la
Vega (@vegaro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboedo aboedo aboedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesrb1 @RevenueCat-Danger-Bot @aboedo