Use SK2 to get Storefront to prevent potential hang #4047
+308
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
5.0.0, there were some observed hangs/freezes that were due to attempting to get the Storefront.The Storefront was being accessed via a SK1 API because it needed to get be a non-async call to set the value for the
X-Storefrontheader. However, this seems to sometimes hang when using SK2 by default. This doesn't happen all the time and has been observed in the simulator.This will change to use the SK2 API for Storefront if available.
Description
Asynchronously sets and caches the storefront in
SystemInfo