Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[External] Add missing SwiftUI environment for previews (#4109) via @noahsmartin #4110

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Jul 24, 2024

Motivation

These two previews were crashing due to expecting objects in the SwiftUI environments that were not added in the preview provider

Description

Adds the two missing environment objects, tested by uploading to emerge and confirming the snapshots of these previews rendered without crashing

<!-- Thank you for contributing to Purchases! Before pressing the
"Create Pull Request" button, please provide the following: -->

### Checklist
- [ ] If applicable, unit tests
- [ ] If applicable, create follow-up issues for `purchases-android` and
hybrids

### Motivation
These two previews were crashing due to expecting objects in the SwiftUI
environments that were not added in the preview provider

### Description
Adds the two missing environment objects, tested by uploading to emerge
and confirming the snapshots of these previews rendered without crashing
@aboedo aboedo added the ci label Jul 24, 2024
@aboedo aboedo requested a review from a team July 24, 2024 20:24
@aboedo aboedo self-assigned this Jul 24, 2024
@aboedo aboedo merged commit d015f38 into main Jul 24, 2024
4 checks passed
@aboedo aboedo deleted the noahsmartin/addMissingEnv branch July 24, 2024 21:08
@fire-at-will fire-at-will mentioned this pull request Jul 25, 2024
nyeu pushed a commit that referenced this pull request Oct 2, 2024
…noahsmartin (#4110)

## Motivation
These two previews were crashing due to expecting objects in the SwiftUI
environments that were not added in the preview provider

## Description
Adds the two missing environment objects, tested by uploading to emerge
and confirming the snapshots of these previews rendered without crashing

Co-authored-by: Noah Martin <noahm444@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants