Fixes trigger_all_tests.yml triggering on every issue comment

[JayShortway]

Bug

The trigger_all_tests.yml workflow triggers for every issue comment. It doesn't check that the comment body matches "@RCGitBot please test".

You can see this if you check the latest workflow runs, and click a few of the comments in that list.

For example, this run was triggered by this comment:

This does add noise to the overall schemes in Xcode, let me know if that feels like a bit too much

Also, these workflow runs all fail.

Fix

Checking rhysd.github.io/actionlint for the trigger_all_tests.yml file at 68ac257 (HEAD of main at the time of writing) shows this error:

if: condition "${{ github.event.issue.pull_request }} &&\ngithub.event.comment.body == '@RCGitBot please test' &&\ngithub.repository == 'RevenueCat/purchases-ios'\n" is always evaluated to true because extra characters are around ${{ }}

The fix is to remove the curly braces altogether. Omitting the curly braces is okay in if conditions, according to the GitHub Actions docs:

The exception to this rule is when you are using expressions in an if clause, where, optionally, you can usually omit ${{ and }}.

(I tried moving the closing curly braces (}}) to the end of the last condition, but that didn't please the linter.)

[tonidero]

Thanks for doing this!

[aboedo]

+100, thanks for taking care of it!