Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customer Center] Fix BackendGetCustomerCenterConfigTests #4124

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Jul 29, 2024

Fix BackendGetCustomerCenterConfigTests after a wrong merge. This was changed in #4048

@vegaro vegaro marked this pull request as draft July 29, 2024 08:04
@vegaro vegaro marked this pull request as ready for review July 29, 2024 10:11
@vegaro vegaro requested a review from a team July 29, 2024 10:11
@vegaro vegaro added test and removed pr:fix A bug fix labels Jul 29, 2024
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,26 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm we were missing snapshot tests for watchOS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something must have changed in main because I remember WatchOS tests were using snapshots of iOS13, so someone must have fixed it

@vegaro vegaro merged commit 29340ca into integration/customer_support_workflow Jul 29, 2024
4 checks passed
@vegaro vegaro deleted the fix-BackendGetCustomerCenterConfigTests branch July 29, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants