Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customer Center] Use system navigation titles #4161

Conversation

codykerns
Copy link
Member

@codykerns codykerns commented Aug 8, 2024

  • Uses system navigation titles instead of text views for screen titles
  • Display subtitle for the manage subscriptions screen
  • improves preview test data with some standard default colors
  • fixes progress view tint color
New Old
New Version Old Version

@codykerns codykerns marked this pull request as ready for review August 8, 2024 20:19
@codykerns codykerns requested a review from a team August 8, 2024 20:20
Copy link
Contributor

@jamesrb1 jamesrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like good changes to me.

@@ -69,6 +63,8 @@ struct FeedbackSurveyView: View {
promoOfferDetails: promotionalOfferData.promoOfferDetails)
})
}
.navigationTitle(self.viewModel.feedbackSurveyData.configuration.title)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

@codykerns codykerns merged commit 3662879 into integration/customer_support_workflow Aug 8, 2024
5 checks passed
@codykerns codykerns deleted the cody/customer_center_navigation_polish branch August 8, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants