[Customer Center] Improving customer center buttons #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codykerns
commented
Aug 9, 2024
codykerns
commented
Aug 9, 2024
codykerns
commented
Aug 9, 2024
|
Looks good, will give this a thoughtful review Monday morning. |
jamesrb1
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
I think these are good changes, nice attention to detail. Pre-approving, but please see comments.
Side comment: I think this title area needs some UI design changes - it looks a bit cramped (localization may be hard), and having the dismiss button the same size and on the same as the screen's title makes the visual hierarchy not great.
jamesrb1
approved these changes
Aug 14, 2024
Comment on lines
+89
to
99
| var body: some View { | ||
| if #available(iOS 16.0, *) { | ||
| NavigationStack { | ||
| content | ||
| } | ||
| } else { | ||
| NavigationView { | ||
| content | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This view will always be presented modally in some manner? If so this is fine, but if someone were to add this to an existing navigation stack, weird things could happen.
Additionally, I see we've used this pattern twice, if we use it a third time, should consider creating a component we can reuse for this.
There was a problem hiding this comment.
The modal question is one we'll need to answer, good call 👍
Agreed on the reusable component - will pull this out into a new component in a separate PR.
vegaro
approved these changes
Aug 14, 2024
joshdholtz
added a commit
that referenced
this pull request
Aug 22, 2024
**This is an automatic release.** ### New Features * Price rounding logic (#4132) via James Borthwick (@jamesrb1) ### Bugfixes * [Customer Center] Migrate to List style (#4190) via Cody Kerns (@codykerns) * [Paywalls] Improve locale consistency (#4158) via Josh Holtz (@joshdholtz) * Set Paywalls Tester deployment target to iOS 15 (#4196) via James Borthwick (@jamesrb1) * [Customer Center] Hide Contact Support button if URL can't be created (#4192) via Cesar de la Vega (@vegaro) * Fix the setting for SKIP_INSTALL in Xcode project (#4195) via Andy Boedo (@aboedo) * [Customer Center] Improving customer center buttons (#4165) via Cody Kerns (@codykerns) * Revert workaround for iOS 18 beta 5 SwiftUI crash (#4173) via Mark Villacampa (@MarkVillacampa) * [Paywalls] Make iOS version calculation lazy (#4163) via Mark Villacampa (@MarkVillacampa) * [Paywalls] Observe `PurchaseHandler` when owned externally (#4097) via James Borthwick (@jamesrb1) ### Other Changes * [Customer Center] Clean up colors in WrongPlatformView and NoSubscriptionsView (#4204) via Cesar de la Vega (@vegaro) * Fix failing `all-tests` and retry more flaky tests (#4188) via Josh Holtz (@joshdholtz) * Compatibility content unavailable improvements (#4197) via James Borthwick (@jamesrb1) * Create lane to enable customer center (#4191) via Cesar de la Vega (@vegaro) * XCFramework artifacts in CircleCI (#4189) via Andy Boedo (@aboedo) * [Customer Center] CustomerCenterViewModel checks whether the app is the latest version (#4169) via JayShortway (@JayShortway) * export RevenueCatUI xcframework (#4172) via Andy Boedo (@aboedo) * Corrects references from ManageSubscriptionsButtonStyle to ButtonsStyle. (#4186) via JayShortway (@JayShortway) * Speed up carthage installation tests (#4184) via Andy Boedo (@aboedo) * Customer center improvements (#4166) via James Borthwick (@jamesrb1) * replace `color(from colorInformation:)` global with extension (#4183) via Andy Boedo (@aboedo) * Fix tests in main (#4174) via Andy Boedo (@aboedo) * Enable customer center tests (#4171) via James Borthwick (@jamesrb1) * [Customer Center] Initial implementation (#3967) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Josh Holtz <me@joshholtz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements around buttons for Customer Center. Several changes for the case where the customer center is presented full screen but wasn't dismiss-able.
NoSubscriptionsView
Button styles
ManageSubscriptionButtonStyletoProminentButtonStyleas it's used elsewhereSubtleButtonStylebutton style (standard, borderless style)WrongPlatformView
ManageSubscriptionsView