Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedbackSurveyCompleted event to Customer Center events #4194

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Aug 16, 2024

Sends a feedbackSurveyCompleted event when an option in the feedback survey is pressed

@vegaro vegaro added pr:feat A new feature pr:fix A bug fix feat:Customer Center and removed pr:feat A new feature labels Aug 16, 2024
@vegaro vegaro marked this pull request as ready for review August 29, 2024 15:54
@vegaro vegaro requested a review from a team August 29, 2024 15:54
Copy link
Contributor

@jamesrb1 jamesrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than enabling customer center.

RevenueCat.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
RevenueCat.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Other than the already mentioned comments.

@vegaro vegaro enabled auto-merge (squash) August 30, 2024 12:03
@vegaro vegaro merged commit 465ab0f into main Aug 30, 2024
5 checks passed
@vegaro vegaro deleted the feedback-survey-callbacks branch August 30, 2024 12:09
vegaro pushed a commit that referenced this pull request Sep 5, 2024
**This is an automatic release.**

### Bugfixes
* [Customer Center] Build `WrongPlatformView` from JSON (#4234) via
Cesar de la Vega (@vegaro)
* Add `feedbackSurveyCompleted` event to Customer Center events (#4194)
via Cesar de la Vega (@vegaro)
### Other Changes
* [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico
(@tonidero)
* Update README.md (#3986) via Khoa (@onmyway133)
nyeu pushed a commit that referenced this pull request Oct 2, 2024
Sends a `feedbackSurveyCompleted` event when an option in the feedback
survey is pressed
nyeu pushed a commit that referenced this pull request Oct 2, 2024
**This is an automatic release.**

### Bugfixes
* [Customer Center] Build `WrongPlatformView` from JSON (#4234) via
Cesar de la Vega (@vegaro)
* Add `feedbackSurveyCompleted` event to Customer Center events (#4194)
via Cesar de la Vega (@vegaro)
### Other Changes
* [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico
(@tonidero)
* Update README.md (#3986) via Khoa (@onmyway133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants