Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes paywalls on iOS 15 when the close button is on. #4203

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jamesrb1
Copy link
Contributor

@jamesrb1 jamesrb1 commented Aug 21, 2024

On iOS 15, some paywalls (1 and 2), when the close button was turned on, would not show all of the images, and the text would not wrap as expected. This PR fixes this issue.

@jamesrb1 jamesrb1 added the pr:fix A bug fix label Aug 21, 2024
@jamesrb1 jamesrb1 marked this pull request as ready for review August 21, 2024 04:06
@jamesrb1 jamesrb1 requested a review from a team August 21, 2024 04:06
@jamesrb1 jamesrb1 changed the title Fixes paywalls on iOS 15 when the close button is set to be displayed. Fixes paywalls on iOS 15 when the close button is on. Aug 21, 2024
Now that it’s iOS 16, we can use a `NavigationStack`.
@joshdholtz
Copy link
Member

@RCGitBot please test

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I started a running of all tests on this to make sure that the RCUI tests still pass for iOS 15 or if we need to regenerate them 🤷‍♂️

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! There are still probably more improvements we could do but this is real good start since what out there is pretty broken 😬

:shipit:

@jamesrb1
Copy link
Contributor Author

Converting back to draft - this needs a bit more work to correct a knock on effect.

@jamesrb1 jamesrb1 marked this pull request as draft August 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants