Paywall Components Localized Strings #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Paywalls/Components/PaywallComponentBases.swift
tonidero
reviewed
Sep 5, 2024
Tests/TestingApps/PaywallsTester/PaywallsTester/Extensions/ArrayExtensions.swift
Outdated
Show resolved
Hide resolved
Sources/Paywalls/Components/PaywallComponentPropertyTypes.swift
Outdated
Show resolved
Hide resolved
|
@RCGitBot please test |
joshdholtz
requested changes
Sep 5, 2024
RevenueCatUI/Templates/Components/TemplateComponentsView+extensions.swift
Outdated
Show resolved
Hide resolved
Tests/TestingApps/PaywallsTester/PaywallsTester/UI/Views/SamplePaywallsList.swift
Outdated
Show resolved
Hide resolved
|
Changing labels from |
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
- Adds localized string support to paywall components -This is primarily done in `TemplateComponentsView`'s static function `chooseLocalization`. - Validates that promised localized strings are actually available. -This is done as component view models are created (see `TextComponentViewModel`), by throwing if an expected key is not present: `self.text = try localizedStrings.string(key: component.textLid)` -This pattern should be followed for every property that represents a localized string id, which ensures a non-nil value for every value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds localized string support to paywall components
-This is primarily done in
TemplateComponentsView's static functionchooseLocalization.Validates that promised localized strings are actually available.
-This is done as component view models are created (see
TextComponentViewModel), by throwing if an expected key is not present:self.text = try localizedStrings.string(key: component.textLid)-This pattern should be followed for every property that represents a localized string id, which ensures a non-nil value for every value.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-03.at.17.39.47.mov