Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renable latest DocC #4240

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Renable latest DocC #4240

wants to merge 5 commits into from

Conversation

jamesrb1
Copy link
Contributor

@jamesrb1 jamesrb1 commented Sep 4, 2024

DocC has fixed the issue, and this PR reverts our package files to use the plugin's latest version, as it was before.

Unsure if we need to check its output somehow, or how best to do that.

@jamesrb1
Copy link
Contributor Author

jamesrb1 commented Sep 4, 2024

@RCGitBot please test

@jamesrb1 jamesrb1 added the build label Sep 4, 2024
@jamesrb1 jamesrb1 marked this pull request as ready for review September 4, 2024 19:23
@jamesrb1 jamesrb1 requested a review from a team September 4, 2024 19:23
@aboedo
Copy link
Member

aboedo commented Sep 4, 2024

there are a couple of fastlane lanes that you can use to generate the docs and preview them, preview_docs and build_docs

@aboedo
Copy link
Member

aboedo commented Sep 4, 2024

look for this:

https://revenuecat.github.io/purchases-ios-docs/5.0.0/documentation/revenuecat/purchases/offerings()

the description should be the one for the method, not "inherited" (TIL the current version is broken)

@aboedo
Copy link
Member

aboedo commented Sep 4, 2024

@aboedo
Copy link
Member

aboedo commented Sep 5, 2024

@jamesrb1 were you able to check?

@jamesrb1
Copy link
Contributor Author

jamesrb1 commented Sep 5, 2024

I'm unable to compile the docs on main and this branch because it's trying to use macOS instead of iOS. Trying to figure this out....

[16:43:08]: $ xcrun --sdk iphonesimulator --show-sdk-path
[16:43:08]: ▸ /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk
[16:43:08]: ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[16:43:08]: Step: swift build --target RevenueCat -Xswiftc -sdk -Xswiftc /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk -Xswiftc -target -Xswiftc arm64-apple-ios16.1-simulator -Xswiftc -emit-symbol-graph -Xswiftc -emit-symbol-graph-dir -Xswiftc .build
[16:43:08]: ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[16:43:08]: $ swift build --target RevenueCat -Xswiftc -sdk -Xswiftc /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk -Xswiftc -target -Xswiftc arm64-apple-ios16.1-simulator -Xswiftc -emit-symbol-graph -Xswiftc -emit-symbol-graph-dir -Xswiftc .build
[16:43:08]: ▸ warning: 'purchases-ios': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
[16:43:08]: ▸ /Users/jamesborthwick/GitHub/purchases-ios/RevenueCatUI/RevenueCatUIDev.xctestplan
[16:43:08]: ▸ Building for debugging...
[16:43:08]: ▸ [0/4] Write sources
[16:43:08]: ▸ [1/4] Copying Info.plist
[16:43:08]: ▸ [2/4] Copying PrivacyInfo.xcprivacy
[16:43:08]: ▸ [3/4] Write swift-version--58304C5D6DBC2206.txt
[16:43:11]: ▸ error: emit-module command failed with exit code 1 (use -v to see invocation)
[16:43:11]: ▸ [5/277] Emitting module RevenueCat
[16:43:11]: ▸ <unknown>:0: warning: using sysroot for 'MacOSX' but targeting 'iPhone'
[16:43:11]: ▸ /Users/jamesborthwick/GitHub/purchases-ios/Sources/Attribution/AttributionFetcher.swift:17:8: error: cannot load underlying module for 'UIKit'
[16:43:11]: ▸ import UIKit
[16:43:11]: ▸ ^
[16:43:11]: ▸ <module-includes>:1:9: note: in file included from <module-includes>:1:
[16:43:11]: ▸ #import "Headers/StoreKit.h"
[16:43:11]: ▸ ^
[16:43:11]: ▸ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks/StoreKit.framework/Headers/StoreKit.h:13:9: note: in file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks/StoreKit.framework/Headers/StoreKit.h:13:
[16:43:11]: ▸ #import <StoreKit/SKCloudServiceSetupViewController.h>
[16:43:11]: ▸ ^

@jamesrb1
Copy link
Contributor Author

jamesrb1 commented Sep 6, 2024

@aboedo I wasn't able to get it running locally using Xcode 15 and Xcode 14 (which the CI machine uses) won't run on Sonoma.... but I'm on my way to having the CI machine make the output available as an artifact, will finish this up tomorrow.

@aboedo
Copy link
Member

aboedo commented Sep 6, 2024

@jamesrb1 I'm a bit confused as to why we need to take care of this now, was it blocking a release?

@jamesrb1
Copy link
Contributor Author

jamesrb1 commented Sep 6, 2024

It's not blocking a release, but when you asked about it, I thought I should take a look. Most of the time I spent on this was after hours. I'll set it aside for now!

@jamesrb1 jamesrb1 marked this pull request as draft September 11, 2024 15:37
@jamesrb1
Copy link
Contributor Author

Converted back to draft as no longer in a mergable state - artifact output needs zipping and code needs tidying.

@vegaro vegaro added pr:other and removed pr:build labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants