Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StoreKit Version Info in GitHub Issues Template #4254

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

fire-at-will
Copy link
Contributor

@fire-at-will fire-at-will commented Sep 9, 2024

Motivation

Version 5.X of the SDK introduced changes to the default StoreKit version used to process purchases and changes to how developers can override the StoreKit version used by the SDK. This PR updates the GH Issue template to reflect these changes.

Description

  • Marks StoreKit2 as enabled by default, since that's the new default in SDK versions >=5.0.0.
  • Updates the comments related to the StoreKit versions to reflect:
    • The default StoreKit versions used on SDK versions <5.X and >=5.X
    • The code used to override the StoreKit version in version >5.X of the SDK.

Open Questions

This should be merged at some point, but we may want to hold off until the 5.X SDKs have a larger adoption. I'm open to thoughts here!

@fire-at-will
Copy link
Contributor Author

Linting is failing in CI, but it's unrelated to these changes:
Screenshot 2024-09-09 at 9 16 56 AM

@fire-at-will fire-at-will self-assigned this Sep 9, 2024
@fire-at-will fire-at-will merged commit b0dff5b into main Sep 12, 2024
5 checks passed
@fire-at-will fire-at-will deleted the update-gh-issue-template-sk2 branch September 12, 2024 15:25
@vegaro vegaro added pr:other and removed pr:docs labels Sep 17, 2024
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants