Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not embed RevenueCat.framework in RevenueCatUI #4256

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Sep 9, 2024

This should fix #4250 by marking RevenueCat.framework as Do not embed in RevenueCatUI

@vegaro vegaro added the pr:build label Sep 9, 2024
@vegaro vegaro requested a review from a team September 9, 2024 16:01
@vegaro
Copy link
Contributor Author

vegaro commented Sep 9, 2024

@RCGitBot please test

@vegaro
Copy link
Contributor Author

vegaro commented Sep 10, 2024

just checked exporting and I don't see the RevenueCatUI.xcframework/ios-arm64_x86_64-maccatalyst/RevenueCatUI.framework/Versions/A/Frameworks/RevenueCat.framework anymore inside the xcframework, so I am going to merge this and throw a release

@vegaro vegaro merged commit 55e7937 into main Sep 10, 2024
33 checks passed
@vegaro vegaro deleted the do-not-embed-revenuecat branch September 10, 2024 16:50
This was referenced Sep 11, 2024
nyeu pushed a commit that referenced this pull request Oct 2, 2024
This should fix #4250 by marking RevenueCat.framework as Do not embed in
RevenueCatUI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New RevenueCatUI.xcframework is causing upload issues
2 participants