Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Temp][Paywall Components] Match properties and behavior with frontend dashboard #4260

Closed
wants to merge 110 commits into from
Closed

[Temp][Paywall Components] Match properties and behavior with frontend dashboard #4260

wants to merge 110 commits into from

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Sep 11, 2024 •
edited
Loading

⚠️ Going to make cleaner PRs from this

Motivation

Coming soon

Description

Coming soon

joshdholtz and others added 30 commits August 29, 2024 15:01
@joshdholtz @jamesrb1
New PaywallComopnentViewModels to support localization needs
29f4506 
# Conflicts:
#	Sources/Paywalls/Components/PaywallComponentBases.swift
@jamesrb1
Remove duplicate extension
6c69a69
@jamesrb1
PublicForExternalTesting
5b49cfb
@jamesrb1
Make ComponentType Sendable
7b4ecad
@jamesrb1
Need to revisit how we’re doing defaults
1151d76
@jamesrb1
Move recursive VM creation into stack initializer
cbba781
@jamesrb1
Safely unwrap text localizations
f0acb4e
@jamesrb1
Gettin’ those VMs movin’! (text component)
2903331
@jamesrb1
Missing from last commit
588016f
@jamesrb1
needs mainactor
f15f28b
@jamesrb1
Get rid of main actor (for now)
750e38d
@jamesrb1
Restore clobbered code
ebf76c9
@jamesrb1
unlocalized fallbacks in text
b7779b8
@jamesrb1
Image Component VM
205cc83
@jamesrb1
Spacer VM
c912c70
@jamesrb1
LinkButtonComponentViewModel
0a803f3
@jamesrb1
viewmodel’s url
8e50c37
@jamesrb1
Move last of SwiftUI out of model data
19383a7
@jamesrb1
Missing from last commit
bbd3535
@jamesrb1
Viewmodel view
526a905
@jamesrb1
Add public for external
7b46b9a
@jamesrb1
ViewModels into separate files
9e72bad
@jamesrb1
Rename file
a5c08a3
@jamesrb1
File rename
11c4204
@jamesrb1
Move various structs into separate file
9e28652
@jamesrb1
Project file file changes
3c4ff47
@jamesrb1
No more data
020ddbd
@jamesrb1
Project file
a7be7af
@jamesrb1
PaywallComponent code organization
a30f20d
@jamesrb1
Not needed
9a20721
jamesrb1 and others added 24 commits September 4, 2024 12:38
@jamesrb1
Missing from last commit
8a91f3a
@jamesrb1
Make all components private
ece1b5a
@jamesrb1
lint
6dff9ad
@jamesrb1
…
3354b5a
@jamesrb1
Merge branch 'main' of https://github.com/RevenueCat/purchases-ios in…
9554b37 
…to paywalls-components/localiztion-take-2-v2-pt2

# Conflicts:
#	RevenueCat.xcodeproj/project.pbxproj
#	RevenueCatUI/Data/Strings.swift
#	RevenueCatUI/Templates/Components/Image/ImageComponentViewModel.swift
#	RevenueCatUI/Templates/Components/LinkButton/LinkButtonComponentViewModel.swift
#	RevenueCatUI/Templates/Components/PaywallComponentViewModel.swift
#	RevenueCatUI/Templates/Components/Stack/StackComponentViewModel.swift
#	RevenueCatUI/Templates/Components/TemplateComponentsView.swift
#	RevenueCatUI/Templates/Components/Text/TextComponentViewModel.swift
#	Sources/Networking/Responses/OfferingsResponse.swift
#	Sources/Paywalls/Components/PaywallComponentBase.swift
#	Sources/Paywalls/Components/PaywallComponentPropertyTypes.swift
#	Sources/Paywalls/Components/PaywallTextComopnent.swift
#	Tests/TestingApps/PaywallsTester/PaywallsTester/Config/SamplePaywalls.swift
#	Tests/TestingApps/PaywallsTester/PaywallsTester/UI/Views/SamplePaywallsList.swift
@jamesrb1
Remove offering from LinkButton
86a9404
@jamesrb1
Move printComponents into element-specific array extension
eeb8e9b
@jamesrb1
Add ability to output localizations as json
8c3917b
@jamesrb1
style
d7c8af9
@jamesrb1
Change enum case name
5344225
@jamesrb1
Move PaywallComponents into struct for namespacing.
3bc2c7d
@jamesrb1
Add missing scopes
be6f45f
@jamesrb1
Move PaywallComponent Array/Dict extensions to own file
0246e70
@jamesrb1
Remove old ColorHex and delete TierId type aliases
e57ea74
@jamesrb1
Remove redundant public
f6c9f0e
@jamesrb1
Project update
9afccdc
@jamesrb1
fallbackLocale -> defaultLocale
f743a2a 
with comment
@jamesrb1
Revert accidental clobber
3662564
@jamesrb1
File name matches comment’s file name.
f20f460
@joshdholtz
A mixture of changes while putting the demo together
76bc2a5
@joshdholtz
Doing some manual fixes for max image height
1e2900b
@joshdholtz
Reworked with new LocalizationProvider
8ba1f15
@joshdholtz
Remove unused thing
31cfa17
@joshdholtz
Merge from main
07e2a55
@RevenueCat-Danger-Bot
Copy link

1 Error
🚫 Label the PR using one of the change type labels
Label Description
breaking or pr:breaking Changes that are breaking
build or pr:build Changes that affect the build system
ci or pr:ci Changes to our CI configuration files and scripts
docs or pr:docs Documentation only changes
feat or pr:feat A new feature
fix or pr:fix A bug fix
perf or pr:perf A code change that improves performance
RevenueCatUI or pr:RevenueCatUI A change to the RevenueCatUI library
refactor or pr:refactor A code change that neither fixes a bug nor adds a feature
style or pr:style Changes that don't affect the meaning of the code (white-space, formatting, missing semi-colons, etc
test or pr:test Adding missing tests or correcting existing tests
next_release or pr:next_release Preparing a new release
dependencies or pr:dependencies Updating a dependency
phc_dependencies or pr:phc_dependencies Updating purchases-hybrid-common dependency

Generated by 🚫 Danger

@joshdholtz joshdholtz changed the title [Paywall Components] Match properties and behavior with frontend dashboard [Temp][Paywall Components] Match properties and behavior with frontend dashboard Sep 11, 2024
@joshdholtz
Copy link
Member Author

Closing in favor of #4261

@joshdholtz joshdholtz closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat:Paywall Components pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshdholtz @RevenueCat-Danger-Bot @vegaro @jamesrb1