Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paywall Components] Introduce new LocalizationProvider to be used by the component view models #4262

Draft
wants to merge 3 commits into
base: paywalls-components/matching-properties-and-behaviors-from-dashboard
Choose a base branch
from

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Sep 11, 2024

⚠️ I don't know if this is actually needed anymore 🤔

Motivation

Give view models more structure/control with localizations using the new LocalizationProvider

Description

Problem

  • ImageViewComponent needs both the "preferred locale" and the "default locale"
    • Image is required for at least the default locale

@joshdholtz joshdholtz changed the base branch from main to paywalls-components/matching-properties-and-behaviors-from-dashboard September 11, 2024 01:29
@RevenueCat-Danger-Bot
Copy link

1 Error
🚫 Label the PR using one of the change type labels
Label Description
breaking or pr:breaking Changes that are breaking
build or pr:build Changes that affect the build system
ci or pr:ci Changes to our CI configuration files and scripts
docs or pr:docs Documentation only changes
feat or pr:feat A new feature
fix or pr:fix A bug fix
perf or pr:perf A code change that improves performance
RevenueCatUI or pr:RevenueCatUI A change to the RevenueCatUI library
refactor or pr:refactor A code change that neither fixes a bug nor adds a feature
style or pr:style Changes that don't affect the meaning of the code (white-space, formatting, missing semi-colons, etc
test or pr:test Adding missing tests or correcting existing tests
next_release or pr:next_release Preparing a new release
dependencies or pr:dependencies Updating a dependency
phc_dependencies or pr:phc_dependencies Updating purchases-hybrid-common dependency

Generated by 🚫 Danger

@joshdholtz joshdholtz force-pushed the paywalls-components/introduce-new-localization-provider branch from 1e87ae6 to aba2df3 Compare September 11, 2024 02:20
@joshdholtz joshdholtz changed the title [Paywalls Components] Introduce new LocalizationProvider to be used by the component view models [Paywall Components] Introduce new LocalizationProvider to be used by the component view models Sep 11, 2024
@joshdholtz joshdholtz changed the title [Paywall Components] Introduce new LocalizationProvider to be used by the component view models [Paywall Components] Introduce new LocalizationProvider to be used by the component view models Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants