-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kochava
integration
#4274
Merged
Merged
Add kochava
integration
#4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to update the backend snapshot tests but will hold on that to before merging just in case. Otherwise, this is ready for review! |
vegaro
approved these changes
Sep 16, 2024
1 task
david-berliner
approved these changes
Sep 17, 2024
tonidero
force-pushed
the
add-kochava-integration
branch
from
September 25, 2024 15:19
6f5e058
to
8895e7f
Compare
tonidero
force-pushed
the
add-kochava-integration
branch
from
September 25, 2024 15:22
88b0f3d
to
d0d0cb3
Compare
@RCGitBot please test |
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Reapply "Add `$kochavaDeviceId` attribution convenience method (#4238)" (#4265) This reverts commit f2ce441. * Add userAgent tracking for attribution networks * Fix tests * Add X-Platform-Device header * Rename user agent to device version * Use correct attribution method * [skip ci] Generating new test snapshots (#4278) * [skip ci] Generating new test snapshots (#4279) * [skip ci] Generating new test snapshots (#4280) * [skip ci] Generating new test snapshots (#4281) * [skip ci] Generating new test snapshots (#4282) * [skip ci] Generating new test snapshots (#4283) * Generating new test snapshots (#4284) * Fix ttests --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
kochava
integration.This brings back the work done in #4238 and picks up the work on #4263 (but renaming it to
$deviceVersion
). Finally, it also adds a new header,X-Platform-Device
that will contain the model version