Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kochava integration #4274

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Add kochava integration #4274

merged 14 commits into from
Sep 25, 2024

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Sep 16, 2024

Description

This adds the kochava integration.

This brings back the work done in #4238 and picks up the work on #4263 (but renaming it to $deviceVersion). Finally, it also adds a new header, X-Platform-Device that will contain the model version

  • Hold until integration is complete

@tonidero tonidero added the pr:feat A new feature label Sep 16, 2024
@tonidero
Copy link
Contributor Author

I need to update the backend snapshot tests but will hold on that to before merging just in case. Otherwise, this is ready for review!

@tonidero tonidero marked this pull request as ready for review September 16, 2024 10:01
@tonidero tonidero requested review from david-berliner and a team September 16, 2024 10:02
@tonidero tonidero added the HOLD label Sep 17, 2024
@tonidero tonidero removed the HOLD label Sep 25, 2024
@tonidero
Copy link
Contributor Author

@RCGitBot please test

@tonidero tonidero merged commit fe181bd into main Sep 25, 2024
33 checks passed
@tonidero tonidero deleted the add-kochava-integration branch September 25, 2024 17:59
nyeu pushed a commit that referenced this pull request Oct 2, 2024
* Reapply "Add `$kochavaDeviceId` attribution convenience method (#4238)" (#4265)

This reverts commit f2ce441.

* Add userAgent tracking for attribution networks

* Fix tests

* Add X-Platform-Device header

* Rename user agent to device version

* Use correct attribution method

* [skip ci] Generating new test snapshots (#4278)

* [skip ci] Generating new test snapshots (#4279)

* [skip ci] Generating new test snapshots (#4280)

* [skip ci] Generating new test snapshots (#4281)

* [skip ci] Generating new test snapshots (#4282)

* [skip ci] Generating new test snapshots (#4283)

* Generating new test snapshots (#4284)

* Fix ttests

---------

Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants