Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for app extensions #4531

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Dec 3, 2024

Customer Center broke the build for app extensions, this PR brings an approach similar to

// we can't directly reference UIApplication.shared in case this SDK is embedded into an app extension.
// so we ensure that it's not running in an app extension and use selectors to call UIApplication methods.
func openURLIfNotAppExtension(url: URL) {
to the Customer Center

@vegaro vegaro marked this pull request as ready for review December 4, 2024 12:29
@vegaro vegaro requested a review from a team December 4, 2024 12:29
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vegaro vegaro merged commit a5f86e5 into main Dec 4, 2024
7 checks passed
@vegaro vegaro deleted the sdk-3670-customer-center-broken-in-app-extensions branch December 4, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants