-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Test if Package.swift is valid on CI for older tooling #4697
base: main
Are you sure you want to change the base?
Conversation
2 cents from a bystander: This is nice! 5.15.0 didn't seem to go out smoothly to me (so was 5.14.0). Agree that the Swift package files should have been validated by CI per-commit. Another problem I noticed is related to pbxproj. Any plan to stop tracking it (xcodeproj in general)? I myself encountered merge conflicts while working on my branches. It just doesn't scale as you welcome more developers and bots to the project. Pinterest stopped tracking xcodeproj many many years ago. xcodegen works well for us. So did Tulsi back when we built with bazel. Xcode 16's buildable folders looks promising. Perhaps you are holding out for it? |
@nguyenhuy the plan is to integrate tuist at some point. So yes, it will eventually disappear =) |
@facumenzella That's great to hear! If it was up to me I'd put it quite high on my list, because:
But of course you all have the complete picture of the read map and priorities so it's your call. |
6551462
to
774dc6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! :chefskiss:
Motivation
This PR aims to add a quick way of validating Package.swift. At least the version that are not tested on every PR (so probably only 5.7 and 5.8 are enough)
Tons of things failed on the last release #4692, and this was one of them.