Add SyncPurchases method overload that accepts a callback as parameter #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
approved these changes
Aug 16, 2024
MarkVillacampa
pushed a commit
that referenced
this pull request
Aug 19, 2024
**This is an automatic release.** ### New Features * Add SyncPurchases method overload that accepts a callback as parameter (#493) via Mark Villacampa (@MarkVillacampa) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.0.1 (#491) via RevenueCat Git Bot (@RCGitBot)
kaushikpaperboat
added a commit
to Kiddopia/purchases-unity
that referenced
this pull request
Aug 23, 2024
* commit '2ad738987fe4ff8fc27f05cef2bf15395cab67ce': Update VERSIONS.md Version bump for 7.1.0 Add SyncPurchases method overload that accepts a callback as parameter (RevenueCat#493) [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.0.1 (RevenueCat#491) Release/7.0.0 (RevenueCat#490) `Amazon`: Add getAmazonLWAConsentStatus method to support Quick Subscribe (RevenueCat#442) Update Deferred proration mode value to match BC7 (RevenueCat#489) Add support new native majors (RevenueCat#485) Bump rexml from 3.2.9 to 3.3.3 (RevenueCat#486) Bump danger from 9.4.3 to 9.5.0 (RevenueCat#487) Bump fastlane from 2.221.1 to 2.222.0 (RevenueCat#480) Fix `Gemfile.lock` with new fastlane plugin dependencies (RevenueCat#479) Update `VERSIONS.md` to include Billing client version and update fastlane plugin (RevenueCat#476) Update Unity IAP compatiiblity (RevenueCat#475) [AUTOMATIC] Release/6.10.0 (RevenueCat#474) Add support for `DEFERRED` upgrades and updates purchases-hybrid-common to 11.1.0 (RevenueCat#472) [AUTOMATIC BUMP] Updates purchases-hybrid-common to 11.0.0 (RevenueCat#470) Bump fastlane from 2.221.0 to 2.221.1 (RevenueCat#468) Bump fastlane from 2.220.0 to 2.221.0 (RevenueCat#466) [AUTOMATIC] Release/6.9.7 (RevenueCat#465) # Conflicts: # .version # CHANGELOG.latest.md # CHANGELOG.md # RevenueCat/Plugins/Android/PurchasesWrapper.java # RevenueCat/Plugins/iOS/PurchasesUnityHelper.m # RevenueCat/package.json # VERSIONS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically,
SyncPurchasesdidn't return a callback in Android (it did on iOS) so for hybrids we were forced to not accept a callback.This is problematic because you can't know for sure when the
SyncPurchasesrequest finished, in order to for example callgetCustomerInfoto get updated entitlements.We recently updated PHC adding a version of the
SyncPurchasesmethod that accepts a callback, and this PR brings this improvement to Unity.In order to keep backwards compatibility, and since C# accepts method overloads, we're simply adding a new
SyncPurchasesmethod that accepts a callback.In the future we cal release a new minor that deprecates the old
SyncPurchasesmethod without callback.