Skip to content

4.1.4 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2022
Merged

4.1.4 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
707c712
Fix false positive of hash collision when a mod uses the same file ov…
Cloudate9 Jun 4, 2022
8d191e6
Version bump
Cloudate9 Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {
}

group = "com.github.reviversmc.themodindex.validation"
version = "4.1.3"
version = "4.1.4"

repositories {
mavenCentral()
Expand Down
18 changes: 16 additions & 2 deletions src/main/kotlin/com/github/reviversmc/themodindex/validation/Validation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,27 @@ fun main(args: Array<String>) {
val availableManifests = indexJson.identifiers.map {
if (it.lowercase() != it) throw IllegalStateException("Identifier \"$it\" is not lowercase.")
if (it.split(":").size != 3) throw IllegalStateException("Identifier \"$it\" is not in the format \"modloader:modname:hash\".")
it.substring(0, it.lastIndexOf(":"))
it.substringBeforeLast(":")
}.distinct()

val versionHashes = indexJson.identifiers.map { it.split(":")[2] }

//Protect against the rare chance where we have a hash collision
if (versionHashes != versionHashes.distinct()) throw IllegalStateException("Duplicate version hashes found.")
if (versionHashes != versionHashes.distinct()) {
val distinctHashes = versionHashes.distinct()
for (i in distinctHashes.indices) {
if (versionHashes[i] != distinctHashes[i]) { //Duplicate found. The duplicate is versionHashes[i]
val collidedIdentifiers =
indexJson.identifiers.filter { it.substringAfterLast(":") == versionHashes[i] }
val name = collidedIdentifiers.first().split(":")[1]
if (collidedIdentifiers != collidedIdentifiers.filter { it.split(":")[1] == name }) {
throw IllegalStateException("Hash collision found for the follow projects. A hash collision occurs when two or more different projects (the same project for a different mod loader does not count as separate projects) have the same hash for a file.\n" +
"Projects: ${collidedIdentifiers.joinToString(", ")}\n" +
"Hash: $versionHashes[$i]")
}
}
}
}

println("Index file validated successfully.")

Expand Down